[linux-dvb] [PATCH 3/6] DVB-PinnSat: Remove op_sync_orin and irq_err_ignore

Edgar Toernig froese at gmx.de
Tue Jan 10 18:15:44 CET 2006


Manu Abraham wrote:
>
> Edgar Toernig wrote:
> 
> >The resulting codes is much cleaner than before and gives the same
> >behaviour as your 'minimal size patch'.
> 
> I would prefer the individual card-sections/glue-logic to handle that 
> part rather than the the common driver, leaving no options later.

But these flags are _not effecting_ the glue-logic.  Why is there
a 'the common driver'?  Maybe because it handles the common part?
These flags were ad hoc hacks that should have never been accepted
in the first place.  Even the still present controlreg parameter
had better been some kind of enum: MODE_PARALLEL/SERIAL/HS_SERIAL
or so.

Btw, it's your patch that leaves no options - you disable the dma
error reporting completely.  I can turn them on at runtime via:

 echo 1 >/sys/module/dvb/dvb_bt8xx/parameters/debug

Ciao, ET.



More information about the linux-dvb mailing list