[linux-dvb] [PATCH 3/6] DVB-PinnSat: Remove op_sync_orin and irq_err_ignore

Edgar Toernig froese at gmx.de
Wed Jan 11 15:24:09 CET 2006


Manu Abraham wrote:
>
> Sigmund Augdal Helberg wrote:
> 
> >Any cleanup to the code is an improvement. If the cleanup _proves_ to
> >break something that used to work, then it is a regression. If you are
> >saying that you have contrete issues with this change then please say
> >what they are, otherwise be happy that more people are looking over the
> >code!
> 
> IMHO, as i said in the other post on the same thread, i am not too happy 
> with the changes as it is not a cleanup, but it would be a hindrance 
> later on.

I would call that bullshit.  Convoluted code is a hindrance.

But I won't argue with you any more.  For me it's totally irrelevant
whether the patch gets into mainline.  The driver is working for me
and if future kernels still won't work with the card I'll just change
it again.  That easy.

But IMHO, you're doing neither developers nor users a favour ...

Ciao, ET.



More information about the linux-dvb mailing list