[linux-dvb] [PATCH 3/6] DVB-PinnSat: Remove op_sync_orin and irq_err_ignore

Ernst Herzberg list-linux-dvb at net4u.de
Fri Jan 13 01:30:13 CET 2006


On Wednesday 11 January 2006 15:24, Edgar Toernig wrote:
> Manu Abraham wrote:
> > Sigmund Augdal Helberg wrote:
> > >Any cleanup to the code is an improvement. If the cleanup _proves_ to
> > >break something that used to work, then it is a regression. If you are
> > >saying that you have contrete issues with this change then please say
> > >what they are, otherwise be happy that more people are looking over the
> > >code!
> >
> > IMHO, as i said in the other post on the same thread, i am not too happy
> > with the changes as it is not a cleanup, but it would be a hindrance
> > later on.
>
> I would call that bullshit.  Convoluted code is a hindrance.
>
> But I won't argue with you any more.  For me it's totally irrelevant
> whether the patch gets into mainline.  The driver is working for me
> and if future kernels still won't work with the card I'll just change
> it again.  That easy.

Ups. 

Hey guys, slow down. For me this patch works perfect! Thx, ET. It is the first 
working version of my pinnacle PCTV-S without the thousands of

[.....]
Jan  1 04:07:44 oernie bt878(0): irq FDSR risc_pc=364a7008
Jan  1 04:07:44 oernie bt878(0): irq FDSR risc_pc=364a7008
Jan  1 04:07:44 oernie bt878(0): irq FDSR risc_pc=364a7008
Jan  1 04:07:44 oernie bt878(0): irq FDSR risc_pc=364a7008
Jan  1 04:07:44 oernie bt878(0): irq FDSR risc_pc=364a7008
Jan  1 04:07:44 oernie bt878(0): irq FDSR risc_pc=364a7008
Jan  1 04:07:44 oernie bt878(0): irq FDSR risc_pc=364a7008
Jan  1 04:07:44 oernie bt878(0): IRQ lockup, cleared int mask
Jan  1 04:07:44 oernie bt878(0): irq SCERR risc_pc=364a7000
Jan  1 04:07:44 oernie bt878(0): irq FDSR risc_pc=364a7008
Jan  1 04:07:44 oernie bt878(0): irq FDSR risc_pc=364a7008
Jan  1 04:07:44 oernie bt878(0): irq FDSR risc_pc=364a7008
[.....]

This problems has been reported for years, nobody cared. ET ist the first one 
who provided a working patch. Maybe the patch need some improvements, i don't 
know, maybe for cards i can not test?

Sorry for answering a little bit late, but yesterday i tried v4l-dvb-cvs. The 
horrible kernel crash destroyed my raid5, now i'm back to vanilla 2.6.15 with 
ETs patch.

I vote to push the patch directly to Andrew or Linus ;-)

Thanks, Edgar.

<earny/>



More information about the linux-dvb mailing list