[linux-dvb] Re: Cleanup of whitespace

Mauro Carvalho Chehab mchehab at infradead.org
Mon Jun 19 13:45:05 CEST 2006


Hi, Trent,

Em Dom, 2006-06-18 às 22:36 -0700, Trent Piepho escreveu:
> It's been annoying me how long make commit takes, about 20 seconds on my
> computer.
Yes, it is slow. I have a faster variant on my -git scripts, that works
just at the modified files, but I never cared so much about moving to
mainstream... ;)

>   So I wrote a fix whitespace script that is much much faster, less
> than one second.
Great!
>   When I ran it, it found a lot of whitespace to fix in the
> current Hg version, 100 lines in 34 files.
> 
> The current fix whitespace script will delete spaces at the beginning of a
> line before a tab.  It will delete 1, 2, 3, and 5-7 spaces before the tab, but
> not four spaces!

> For example, look at saa6752hs.c lines 72 to 76.  They start with four spaces
> and then a tab.  It seems like this is exactly the kind of thing the script
> should find.
> 
> Is this intentional?  Or is it a mistake in the fix whitespace script?
This is not intentional. Just a script mistake.
> 
> If I submit a faster script, should I also submit a patch that does a big
> whitespace fix to get all the stuff the current script missed?

Sending those big patches though mailing lists are just a loss of
mailbox space for most people! If you submit such patch, please send it
just to me.
> Or should I
> modify my faster script to copy the way the current one fixes 1 to 8 spaces,
> but skips four spaces?
No. As I said, this were not intentional.

Cheers, 
Mauro.




More information about the linux-dvb mailing list