[linux-dvb] Re: [PATCH] Geniatech Digistar support/Digiwave 103g

Andrew de Quincey adq_dvb at lidskialf.net
Thu Jun 29 11:03:30 CEST 2006


On Thursday 29 June 2006 05:58, Michael Krufky wrote:
> Saqeb,
>
> >diff -r 8feabb5c0eae -r ce921c4dce88
> > linux/drivers/media/dvb/frontends/cx24123.c ---
> > a/linux/drivers/media/dvb/frontends/cx24123.c	Tue Jun 27 03:57:46 2006
> > +++ b/linux/drivers/media/dvb/frontends/cx24123.c	Wed Jun 28 16:56:42
> > 2006 @@ -681,10 +681,10 @@
> > 	switch (voltage) {
> > 	case SEC_VOLTAGE_13:
> > 		dprintk("%s: setting voltage 13V\n", __FUNCTION__);
> >-		return cx24123_writereg(state, 0x29, val | 0x80);
> >+		return cx24123_writereg(state, 0x29, val & 0x7f);
> > 	case SEC_VOLTAGE_18:
> > 		dprintk("%s: setting voltage 18V\n", __FUNCTION__);
> >-		return cx24123_writereg(state, 0x29, val & 0x7f);
> >+		return cx24123_writereg(state, 0x29, val | 0x80);
> > 	default:
> > 		return -EINVAL;
> > 	};
>
> ^^^ How do you know this change is correct?  (I don't doubt it -- I
> wouldn't know)  What problem does this change solve for you?  I think
> you should ask some other users of cards with a cx24123 to confirm that
> this doesnt break anything, and achieves the desired results.

Yeah I was wondering about that; the other DVBS cx24123 cards do seem to work 
correctly with the original setting. Perhaps this new card is simply wired up 
differently. If thats the case you'll need to add a new config parameter 
(e.g. 'voltage_wiring') to the cx24123_config structure in order to support 
both wiring types.



More information about the linux-dvb mailing list