[linux-dvb] [PATCH] fix for CX24123 & low symbol rates

Vadim Catana vcatana at registru.md
Tue Mar 14 07:28:02 CET 2006


Yeasah Pell wrote:
> Anyway, I was reviewing the patch to see if I could notice anything that
> seemed out of place, and I did find one thing that is definitely not
> right (though it doesn't seem to make much of a difference.) The call to
> cx24123_readlnbreg in this part of the patch should be a call to
> cx24123_readreg instead:
> 
> +    /* set the FILTUNE voltage */
> +    val = cx24123_readlnbreg(state, 0x28) & ~0x3;
> +    cx24123_writereg(state, 0x27, state->FILTUNE >> 2);
> +    cx24123_writereg(state, 0x28, val | (state->FILTUNE & 0x3));
> 
> It's clearly intended to preserve the non-FILTUNE bits of register 0x28,
> but instead ends up merging in bits from the stored LNB setup. Seems
> like somebody's fingers got a little too used to typing 'readlnbreg'
> instead of 'readreg' :-)

You are right, my mistake. Thanks for spotting this.
I'm resending the patch.

Regards,
Vadim Catana
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4l-dvb.diff
Type: text/x-patch
Size: 13576 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20060314/71af5b56/v4l-dvb-0001.bin


More information about the linux-dvb mailing list