[linux-dvb] [PATCH 4/4] budget-ci: kzalloc conversion, be slightly more verbose about IR init

Johannes Stezenbach js at linuxtv.org
Wed Mar 29 00:20:01 CEST 2006


On Wed, Mar 22, 2006, Darren Salt wrote:
> Convert to kzalloc.
...
> @@ -1032,7 +1036,7 @@
>  	struct budget_ci *budget_ci;
>  	int err;
>  
> -	if (!(budget_ci = kmalloc(sizeof(struct budget_ci), GFP_KERNEL)))
> +	if (!(budget_ci = kzalloc(sizeof(struct budget_ci), GFP_KERNEL)))
>  		return -ENOMEM;
>  
>  	dprintk(2, "budget_ci: %p\n", budget_ci);

This looks a bit suspicous. Whas the zeroing of *budget_ci
missing before or is it unnecessary?

Anyway, it's not a bad thing to do.


Johannes



More information about the linux-dvb mailing list