[linux-dvb] [PATCH] Fix a bug when tunning C-BAND channels with kaffeine

Andreas Oberritter obi at linuxtv.org
Wed Mar 29 22:31:24 CEST 2006


On Wed, 2006-03-29 at 11:42 -0300, Mauro Carvalho Chehab wrote:
> Instead of asking dst to tune at 981 MHz (5150-4169), it was asking to
> tune at -981 MHz. Since all drivers use unsigned int, it were like if
> trying to tune at 4,293 GHz! DST code have a protection against values
> higher than 2.4 GHz, resulting in no tune at all. 
> 
> The patch just checks if this is happening, and inverts the signal,
> resulting tuning at desired freq of 981 MHz.
> 
> Probably the same patch should be needed on other frontends until
> applications fix it.

Why should frontend drivers work around clearly broken userspace
software? I think it would be better to just refuse tuning to
frequencies smaller than frequency_min and larger than frequency_max (in
dvb_frontend.c).

Since szap does it right the authors of kaffeine have a reference they
can use.

Regards,
Andreas




More information about the linux-dvb mailing list