[linux-dvb] [PATCH] Some changes to the Kbuild help

Michael Krufky mkrufky at linuxtv.org
Thu Mar 30 07:56:39 CEST 2006


Trent Piepho wrote:
> On Wed, 29 Mar 2006, Michael Krufky wrote:
> 
>>I don't want us all to have to constantly update Kconfig help text each
>>time a new card is added. Nobody is going to want to do this, and then
>>the job falls on Mauro or I to keep it updated. I would simply remove
>>the card names.

[snip]

> How about an update to Documentation/dvb/cards.txt, would that be ok?  And
> maybe just a pointer to it from the cx88 Kconfig?

This would require maintainance. Yes, it is easy to do, but the problem 
is that it is just one extra thing to remember. One extra task. One more 
rule to try to enforce. One more thing that some guy will forget. One 
more extra patch that will have to be sent in at the last minute.

Instead, please use the wiki:

[DVB] http://linuxtv.org/wiki
[V4L] http://linuxtv.org/v4lwiki

[snip]

>>>6) cx88 VP-3054 support needs cx88 MT352 support

[snip]

> Rather than appearing under MT352, it goes back up to the top level as if it
> is another video adapter.  Everything after it is messed up as well.  All the
> remaining frontends for cx88 appear directly under the top level, instead of
> under cx88 -> cx88-dvb -> frontends.
> 
> It's somewhat harder to put into an email message, but the option tree from
> xconfig is messed up the same way.
> 
> Is there another way to fix this?

I propose a compromise, please try it out and tell me what you think:

This patch creates a boolean dependency link for VIDEO_CX88_VP3054, so 
that it's tristate value will be the same as that of VIDEO_CX88_DVB

The reason for this patch is to fix up the indentation order within the 
individual frontend selection menus for cx88-dvb.

The patch is correct, although the explanation is a bit difficult. ;-)

diff -r a1d6b1ec9e2d linux/drivers/media/video/cx88/Kconfig
--- a/linux/drivers/media/video/cx88/Kconfig    Thu Mar 30 01:05:16 2006
+++ b/linux/drivers/media/video/cx88/Kconfig    Thu Mar 30 00:43:15 2006
@@ -1,3 +1,8 @@
+config VIDEO_CX88_VP3054
+       tristate
+       default y
+       depends on VIDEO_CX88_DVB && DVB_MT352
+
  config VIDEO_CX88
         tristate "Conexant 2388x (bt878 successor) support"
         depends on VIDEO_DEV && PCI && I2C
@@ -73,10 +78,11 @@
           This adds DVB-T support for cards based on the
           Connexant 2388x chip and the MT352 demodulator.

-config VIDEO_CX88_VP3054
-       tristate "VP-3054 Secondary I2C Bus Support"
-       default m
-       depends on DVB_MT352
+config VIDEO_CX88_DVB_VP3054
+       bool "VP-3054 Secondary I2C Bus Support"
+       default y
+       depends on VIDEO_CX88_DVB_MT352 && !VIDEO_CX88_DVB_ALL_FRONTENDS
+       select VIDEO_CX88_VP3054
         ---help---
           This adds DVB-T support for cards based on the
           Connexant 2388x chip and the MT352 demodulator,


Signed-off-by: Michael Krufky <mkrufky at linuxtv.org>



More information about the linux-dvb mailing list