[linux-dvb] [PATCH] Frontend or51211 - fixes SNR and signal
xyzzy at speakeasy.org
Mon Nov 20 22:42:10 CET 2006
On Sat, 18 Nov 2006, Rusty Scott wrote:
> The attached patch makes changes to the or51211 frontend to match the SNR and
> signal strength methods in the lgdt330x frontend. It removes an embedded log
> function in favor of using the functions in dvb_math. Do not confuse this patch
> with the patch just posted for the or51132 frontend. I'm not sure why 'make
I've fixed up the patches a bit and put them into my repository,
http://linuxtv.org/hg/~tap/v4l-dvb Does everything still look ok?
I've tested the or51132 patch and it seems to work ok with 8-vsb. I
haven't been able to test the or51211 patch. I'm not sure how much testing
it got before, as it didn't compile.
I'd like to verify a couple things. For the or51211, the error register is
only 8 bits? In the or51132 it's 16 bits.
The or51211 patch removed a msleep(3) that appears between most of the i2c
transactions. Is this ok?
The or51132 patch removed some msleep(30) calls too. I added those back in
since the rest of the code had them. Is there anything in the datasheet to
suggest that these are necessary? i.e. after selecting a register you must
wait 30 ms before trying to read it? I wonder if all those msleeps() can
More information about the linux-dvb