[linux-dvb] [PATCH] fix NULL pointer dereference in NOVA T USB2 Remote Control

Patrick Boettcher patrick.boettcher at desy.de
Sun Oct 8 20:45:41 CEST 2006


Hi Mario,

sorry for the delay.

On Sun, 8 Oct 2006, Mario Rossi wrote:

> This patch fixes the NULL pointer exception while using the Remote
> Control for a NOVA T USB2.
> 
> Basically this line was missing (for the properties of the device
> "dvb_usb_device_properties")
> 
>       .size_of_priv     = sizeof(struct dibusb_state),
> 
> I'm not sure the fix is 100% correct since the same line is present
> for the properties of the adapter (dvb_usb_device_adapter_properties),
> both at around line 154 of
> /linux/drivers/media/dvb/dvb-usb/nova-t-usb2.c.
> 
> The question is: the "struct dibusb_state" should be allocated for
> 
> 1) the device
> 2) the adapter
> 3) both

I splitted the struct to take care about the changes. Can you please check 
my repository? I'm always in hurry please forgive me in advance, if there 
is another mistake.

best regards,
Patrick.

--
  Mail: patrick.boettcher at desy.de
  WWW:  http://www.wi-bw.tfh-wildau.de/~pboettch/



More information about the linux-dvb mailing list