[linux-dvb] [PATCH] fix NULL pointer dereference in NOVA T USB2 Remote Control

Mario Rossi mariofutire at googlemail.com
Tue Oct 10 01:10:04 CEST 2006


I've tried your repository a few minutes ago.
The card works (AGC) and te remote control as well (no NULL pointer exception).

What about this patch to remove unnecessary (and misleading) debug
output (it prints the values of the keys in the table up to the value
of the key pressed)?

diff -r 0e4be24ee6c0 linux/drivers/media/dvb/dvb-usb/nova-t-usb2.c
--- a/linux/drivers/media/dvb/dvb-usb/nova-t-usb2.c     Sun Oct 08
20:44:05 2006 +0200
+++ b/linux/drivers/media/dvb/dvb-usb/nova-t-usb2.c     Tue Oct 10
00:07:08 2006 +0100
@@ -90,9 +90,9 @@ static int nova_t_rc_query(struct dvb_us
                        deb_rc("raw key code 0x%02x, 0x%02x, 0x%02x to
c: %02x d: %02x toggle:
%d\n",key[1],key[2],key[3],custom,data,toggle);

                        for (i = 0; i < ARRAY_SIZE(haupp_rc_keys); i++) {
-                               deb_rc("c: %x, d:
%x\n",haupp_rc_keys[i].data,haupp_rc_keys[i].custom);
                                if (haupp_rc_keys[i].data == data &&
                                        haupp_rc_keys[i].custom == custom) {
+                                        deb_rc("c: %x, d:
%x\n",haupp_rc_keys[i].data,haupp_rc_keys[i].custom);
                                        *event = haupp_rc_keys[i].event;
                                        *state = REMOTE_KEY_PRESSED;
                                        if (st->old_toggle == toggle) {


On 10/8/06, Patrick Boettcher <patrick.boettcher at desy.de> wrote:
> Hi Mario,
>
> sorry for the delay.
>
> On Sun, 8 Oct 2006, Mario Rossi wrote:
>
> > This patch fixes the NULL pointer exception while using the Remote
> > Control for a NOVA T USB2.
> >
> > Basically this line was missing (for the properties of the device
> > "dvb_usb_device_properties")
> >
> >       .size_of_priv     = sizeof(struct dibusb_state),
> >
> > I'm not sure the fix is 100% correct since the same line is present
> > for the properties of the adapter (dvb_usb_device_adapter_properties),
> > both at around line 154 of
> > /linux/drivers/media/dvb/dvb-usb/nova-t-usb2.c.
> >
> > The question is: the "struct dibusb_state" should be allocated for
> >
> > 1) the device
> > 2) the adapter
> > 3) both
>
> I splitted the struct to take care about the changes. Can you please check
> my repository? I'm always in hurry please forgive me in advance, if there
> is another mistake.
>
> best regards,
> Patrick.
>
> --
>   Mail: patrick.boettcher at desy.de
>   WWW:  http://www.wi-bw.tfh-wildau.de/~pboettch/
>



More information about the linux-dvb mailing list