[linux-dvb] [PATCH 1/3] Fix a problem during the access to the IER and ISR registers of the SA7146

e9hack e9hack at googlemail.com
Tue Oct 31 18:25:28 CET 2006


Oliver Endriss wrote:
>   
>> Protect the access to the IER/ISR register of the SAA7146 by the device spinlock.
>>     
>
> Imho it is not necessary to protect write operations to the ISR because
> it is a single write-only operation.
>   
You are right.

> SAA7146_IER_DISABLE/SAA7146_IER_ENABLE must be protected by a spinlock
> because it is a read-modify-write operation.
>
> So your patch could be replaced by the attached one.
>
> What do you think?
>
>   
It exist some pieces of code, where the spinlock is already locked and
where the macros are used. It exist a second spinlock within the SAA7146
device structure. Currently, it is unused. This one can be used.

- Hartmut


-------------- next part --------------
A non-text attachment was scrubbed...
Name: saa7146-irq-fix-2.patch
Type: text/x-patch
Size: 1178 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20061031/a00f550f/saa7146-irq-fix-2-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: saa7146-i2c-fix-2.patch
Type: text/x-patch
Size: 1245 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20061031/a00f550f/saa7146-i2c-fix-2-0001.bin


More information about the linux-dvb mailing list