[linux-dvb] Re: MSI Megasky 580 using Uli m9206 -- http://linuxtv.org/hg/~mkrufky/m920x

[Aapo Tahkola]

On Tue, 26 Sep 2006 14:21:08 -0400
Michael Krufky <mkrufky at linuxtv.org> wrote:

> Patrick,
> 
> Could you look over the changesets in this tree and let me know
> whether or not you approve of this?
> 
> Aapo,
> 
> After you sent your patch in to the linux-dvb mailing list, Patrick
> had some comments and requests for certain things to be cleaned up.
> I have not seen any response from you about those requests.

Hehe, it's not like I have heard any reports from the users either...

> In an effort to move things along, I have taken it upon myself to
> clean up your patch.  I've updated it to comply with some of the
> recent changes in the dvb-usb structure, and to use the new
> dvb_attach() method.

Couple improvements in this patch:
-hardware pid filtering no longed enabled unless in usb 1.x mode
-more responsive rc handling
-some minor bug fixes and code refolding
-m9206_write delay dropped(doesn't seem to be needed)

Signed-off-by: Aapo Tahkola <aet at rasterburn.org>

> I have also separated the qt1010 tuner code into a separate header
> file. It has come to my attention, thanks to Markus Rechberger, that
> there may be more fixing to do with regards to the qt1010 stuff...
> but that can be done later, in a separate patch.

I lost the perl scripts used analyse the tuner data so I'm not
really interested in rewriting them just for this. I would probably use
the gl861 based mega sky to check the odd frequencies as it has
slightly simpler i2c.

> I'd like it if you could test the updated tree and confirm that it
> works as expected with your device.  Please clone the following tree:
> 
> http://linuxtv.org/hg/~mkrufky/m920x

It stalls with silence if I modprobe the driver and plug in the stick.
If I plug in and then modprobe, nothing happens.
Compiling linux-2.6.18 to see if that sorts it out. Doesn't seem to be
related to m920x code though...

> 
> You will notice that I have decided to rename the driver from megasky
> to m920x -- I did this for a few reasons:
> 
> 1) There are probably other devices out there based on the m9205,
> m9206 and m9207 chipsets ... Adding support for those devices will
> probably be a matter of updating the code in this driver, in which
> case, the name 'megasky' may be inappropriate.

I think m9207 just fixes the isoch hardware bug.

> 2) There is another device out there, called "MSI Megasky 580", based
> on the gl861 chipset, using the same exact usb id as your device
> based on the m9206 chipset.  This means that MSI released two
> completely different devices, each with the same exact name and USB
> ID!

Actually, I think the newer version has pid of 0x5581, at least
according to the windows driver.

> 3) We should name the driver based on the chipset it uses, rather than
> the Vendor's retail name of the product.

I first thought it would be better to use retail name because of 2).

-- 
Aapo Tahkola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: m920x_my.patch
Type: text/x-patch
Size: 12699 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20060927/e1439bee/m920x_my-0001.bin