[linux-dvb] Re: Hybrid tuner proposal (V4L/DVB)

Johannes Stezenbach js at linuxtv.org
Sun Apr 8 21:58:08 CEST 2007


On Thu, Apr 05, 2007, Markus Rechberger wrote:
> I sent this proposal to several individual developers already around
> 1-2 weeks ago, and received several comments, maybe I should give it a
> try to push a very last discussion about it.
> 
> Video4Linux/DVB Hybrid Tuner Support
> ====================================
...
> >Mauro wrote that requesting the tuner module first and afterwards call an 
> >init function within the driver
> >which requested that module, this might be a solution for using 
> >initialization functions similar to
> >usb_register/usb_deregister.
> >on the other side this would break the dvb_attach approach and it might 
> >require much bigger changes in the
> >dvb framework (?)
> >This approach is currently partly implemented in v4l-dvb-kernel on 
> >mcentral (http://mcentral.de/hg/~mrec/v4l-dvb-kernel)
> 
> a current implementation which uses the unified module approach and a
> similar approach like dvb_attach can be found
> at:
> http://mcentral.de/hg/~mrec/v4l-dvb-experimental
> (see tuner-core.c, v4l_dvb_tuner.h)

In the discussions one month ago I had the impression that serveral
people agreed on this or at least wanted to help to do the
necessary work to get this merged.

All private comments to Markus are fine, but if there's
any interest in getting this stuff merged, you need to show
it publicly.

Any comments on the code are good. Not saying anything is bad.


FWIW, I very briefly looked at
http://mcentral.de/hg/~mrec/v4l-dvb-experimental/file/d1e8753a491b/linux/include/media/v4l_dvb_tuner.h
and I think the V4L_OPS macro is invalid because it yields a pointer
to a variable on the stack which just went out of scope.
This might work by accident, but IMHO gcc is allowed to
reuse the stack space for something else immediately after
the closing brace.


HTH,
Johannes



More information about the linux-dvb mailing list