[linux-dvb] [patch] dvb_net hotplugging support

Oliver Endriss o.endriss at gmx.de
Fri Aug 17 21:47:40 CEST 2007


Trent Piepho wrote:
> On Fri, 17 Aug 2007, Oliver Endriss wrote:
> > Markus Rechberger wrote:
> > > Since this didn't get commented here, Trent did that patch already 2
> > > months ago but it's not included yet. So I recommend to include his
> > > patch.
> > >
> > > http://article.gmane.org/gmane.linux.kernel/543689
> > >
> > > Acked-by: Markus Rechberger <mrechberger at gmail.com>
> >
> > Are you talking about this tiny patch?
> >
> >  	struct dvb_net *dvbnet = dvbdev->priv;
> >
> > -	if (!dvbdev)
> > -		return -ENODEV;
> >
> > If yes,
> > Acked-by: Oliver Endriss <o.endriss at gmx.de>
> >
> > Btw, why is this patch important? Basically it doesn't change anything.
> 
> It checks if dvbdev is NULL after dvbdev already been used.  Coverity spots
> this as a programming mistake (which it is), and Adrian Bunk posts patches
> to fix it.

Sure, but the patch does exactly the same.
It's just hidden behind a function call...

@Mauro:
This patch simply replaces a code block by a function call.
The function does exactly the same as the code block did.
It's safe to apply this patch.

Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.3.9: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------




More information about the linux-dvb mailing list