[linux-dvb] patch 2 / 2: deselect dst and dst-ca if they aren?t needed

hermann pitton hermann-pitton at arcor.de
Mon Feb 5 04:53:12 CET 2007


Am Sonntag, den 04.02.2007, 17:21 +0100 schrieb Uwe Bugla:
> Hi everybody,
> I?ve been sending in this stuff several times now. At my last attempt Mr. Abraham replied: "NACK. The patch is OK, but I first want to see whether
> DVB_CORE_ATTACH works without errors."
> Seeing through the mailing list for a couple of weeks now I never even once noticed at least one complaint that DVB_CORE_ATTACH would not work as it should.
> In the past Mr. Abraham wanted to produce a dvb-bt8xx driver being independent from bttv dependencies (type in "cx878" in google to see yourself what I am talking about). So he and others (like Oliver Endriss for instance - literal citation: "I adjusted my killer patch, so he won?t bother me again") screw and ripped up a working driver and let the rest of the user community of bt8xx DVB cards suffer from their personal incapabilities and lacking experience. This not only resulted in bad flame wars, but also in exactly FOUR unusable kernels as far as the bt8xx driver section is concerned: 2.6.13, 2.6.14, 2.6.15 and 2.6.16! Mr. Chehab himself, who is so much concerned about security issues if patches are not sent in by members of linuxtv.org, never even spurked out a sigh. He just let Abraham produce this horrible disaster doing nothing. At the same time people who only wanted to help and fix all this were fought down by Mr. Abraham in the first front. And his project of a bt
 8x
>  x driver independent from bttv and i2c dependencies still is what it always has been:
> A dead born child! Incomplete unusable rubbish!
> I have already been working and patching those drivers (and their precedents for earlier kernels than 2.6) when Mr. Chehab and Mr. Abraham weren?t even planned as maintainers, and I deeply regret that Gerd Knorr isn?t maintainer anymore. I will not qualify Mr. Chehab or Abraham, as they qualify themselves through their own daily behaviour.
> Just one example: While I was confirming again and again that not only my card never needed a pll library to run (dvb-pll.c - somewhen around October / November of last year) it was Mr. Chehab himself producing a complete nonsense discussion leading to nothing while Michael Krufky at the same time sat down and rewrote the whole thing from scratch which proved me that my criticism was right in place.
> A sophisticated intellectual reaction of a mature great man having real class would have been something like: "Okay, I do not have any idea about this as I am lacking the experience, so lets give it a try." But I obviously expect too much from persons like Chehab and Abraham. It ain?t no fun at all working with that kind of people! And I there?s nothing that I hate more than "Quod licet Iovi non licet bovi" behaviour (If anybody needs a translation for this please feel free to ask me - the concept behind this famous latin saying is a very reactionary one that has absolutely nothing to do with modern democratic behaviour at all). At least one man in Brazil seems to urgently need lessons in modern democratic behaviour. Another one situated somewhere in the United States obviously too.
> 
> So here is my patch again. I do not want to carry it around with me for another ten months, so please push it:
> 
> This patch enables deselecting Mr. Abraham?s dst modules if they aren?t needed. Within the current kernel concept you are forced to compile them and delete them afterwards if you enabled DVB_CORE_ATTACH, which is utmost stupid. With this patch you can make sure that they aren?t compiled at all if you know that you do not need them at all. Above that you save RAM using several DVB-S cards and DVB_CORE_ATTACH works fine and error free:
> 
> Signed-off-by: Uwe Bugla <uwe.bugla at gmx.de>
> 
> --- a/drivers/media/dvb/bt8xx/Makefile
> +++ b/drivers/media/dvb/bt8xx/Makefile
> @@ -1,3 +1,5 @@
> -obj-$(CONFIG_DVB_BT8XX) += bt878.o dvb-bt8xx.o dst.o dst_ca.o
> +obj-$(CONFIG_DVB_BT8XX) += bt878.o dvb-bt8xx.o
> +obj-$(CONFIG_DVB_DST) += dst.o
> +obj-$(CONFIG_DVB_DST_CA) += dst_ca.o
>  
>  EXTRA_CFLAGS = -Idrivers/media/dvb/dvb-core/ -Idrivers/media/video/bt8xx -Idrivers/media/dvb/frontends
> --- a/drivers/media/dvb/bt8xx/Kconfig
> +++ b/drivers/media/dvb/bt8xx/Kconfig
> @@ -9,6 +9,8 @@
>  	select DVB_LGDT330X if !DVB_FE_CUSTOMISE
>  	select DVB_TUNER_LGH06XF if !DVB_FE_CUSTOMISE
>  	select DVB_ZL10353 if !DVB_FE_CUSTOMISE
> +	select DVB_DST if !DVB_DST_CUSTOMISE
> +	select DVB_DST_CA if !DVB_DST_CUSTOMISE
>  	select FW_LOADER
>  	help
>  	  Support for PCI cards based on the Bt8xx PCI bridge. Examples are
> @@ -21,3 +23,35 @@
>  	  an external software decoder to watch TV on your computer.
>  
>  	  Say Y if you own such a device and want to use it.
> +
> +menu "Customise DST support"
> +	depends on DVB_BT8XX
> +
> +config DVB_DST_CUSTOMISE
> +	bool "Customise DST modules to build"
> +	default N
> +	help
> +	  This allows the user to deselect DST drivers for TwinHan and clone cards or cards with
> +	  CA slot. Use this option with care as deselecting drivers which are in fact necessary
> +	  will result in DVB devices which cannot be tuned due to lack of driver support.
> +
> +	  Please note: To deselect these drivers you MUST say y to DVB_CORE_ATTACH above.
> +
> +	  If unsure say N.
> +
> +config DVB_DST
> +	tristate "DST module"
> +	depends on DVB_BT8XX
> +	default m if DVB_DST_CUSTOMISE
> +	help
> +	  A DVB-S tuner module. Say Y when your card is a TwinHan or clone.
> +
> +config DVB_DST_CA
> +	tristate "DST CA module"
> +	depends on DVB_BT8XX
> +	default m if DVB_DST_CUSTOMISE
> +	help
> +	  A DVB-S tuner module. Say Y when your card has a conditional access slot.
> +	  Examples are: TwinHan DST with CA slot, Pinnacle PCTV Sat CI, Chaintech DST-1000, DNTV Live !
> +
> +endmenu
> 
> Best regards
> 
> Uwe
> 

Interesting, signed-off Makefiles.

We still have first class maintainers on v4l and dvb!

Cheers,
Hermann






More information about the linux-dvb mailing list