[linux-dvb] [PATCH] budget-ci IR handling fixups

Oliver Endriss o.endriss at gmx.de
Tue Feb 13 16:19:09 CET 2007


David Härdeman wrote:
> On Tue, February 13, 2007 6:29, Oliver Endriss said:
> > Well, it might be better but it is not correct yet. ;-)
> > ...
> > For a long keypress the driver must produce '1-2-2-2-2-...-2-0' Key
> > events (Reset events omitted).
> 
> I know that. The driver has never gotten this right (neither in the old
> version, the current one or the current one plus this patch).
> 
> Fixing the repeat event handling (and removing the entire debounce logic
> which I suspect was just a way of papering over some of the bugs in the
> driver) is on my todo-list, but it is an issue which is orthogonal to the
> one addressed by the patch.
> 
> At the moment, the driver doesn't work at all, so please apply this patch
> and I'll take a look at repeat handling later.

Ok, applied.

Btw, I noticed that the driver uses static state variables
('prev_toggle', 'ir_key', 'state').

That will cause problems if you are running more than one card.
Better add these variables to 'struct budget_ci_ir' instead.

Oliver

-- 
--------------------------------------------------------
VDR Remote Plugin 0.3.9 available at
http://www.escape-edv.de/endriss/vdr/
--------------------------------------------------------




More information about the linux-dvb mailing list