[linux-dvb] Bug in frontend_init() in budget-av.c

Michael Krufky mkrufky at linuxtv.org
Tue Feb 20 22:34:32 CET 2007


e9hack wrote:
> Hi,
> 
> it seems, that is a bug in frontend_init() in budget-av.c for some DVB-S cards. It exist the following code:
> 
> 	case SUBID_DVBS_KNC1:
> 	case SUBID_DVBS_KNC1_PLUS:
> 	case SUBID_DVBS_EASYWATCH_1:
> 		if (saa->pci->subsystem_vendor == 0x1894) {
> 			fe = dvb_attach(stv0299_attach, &cinergy_1200s_1894_0010_config,
> 					&budget_av->budget.i2c_adap);
> 			if (fe) {
> 				dvb_attach(tua6100_attach, fe, 0x60, &budget_av->budget.i2c_adap);
> 			}
> 
> I think, the last lines must be something like this:
> 
> 			if (fe) {
> 				fe->ops.tuner_ops.set_params = this_is_a_nice_tuning_function;
> 			}


Hartmut,

NO!  Please take a look inside tua6100.c ... you will notice that there are more
tuner_ops being filled besides only set_params.  There is no bug here, the
current code is optimal.

-- 
Michael Krufky




More information about the linux-dvb mailing list