[linux-dvb] Re: [PATCH] Implement repeat key handling in budget-ci IR

[Oliver Endriss]

Trent Piepho wrote:
> On Sun, 25 Feb 2007, Oliver Endriss wrote:
> > > Does the attached patch fix it for you?
> >
> > Ok, I tried to compile against 2.6.18 and it still doesn't work.
> > The attached patch fixes it...
> 
> The bool type was added here, oct 1 2006:
> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6e21828743247270d09a86756a0c11702500dbfb
> 
> This was for kernel 2.6.19.  It looks like budget-ci is the first v4l-dvb
> driver to use it, so there wasn't any pre-2.6.19 compat code for it yet.
> 
> I suggest adding to compat.h:
> 
> #ifndef bool
> #define int bool
> #endif

Well, should be
  #define bool int
;-)

Anyway, bool is a typedef, and the C preprocessor cannot detect a
typedef. So your #define would replace all occurrences of bool with int,
no matter which kernel you run.

It has already been fixed in HG master:
I added 'typedef int bool;' for kernel < 2.6.19.
Tested ok with 2.6.18 and 2.6.20.

Oliver

-- 
--------------------------------------------------------
VDR Remote Plugin 0.3.9 available at
http://www.escape-edv.de/endriss/vdr/
--------------------------------------------------------