[linux-dvb] [PATCH] dvb-core: Fix several locking related problems.

Simon Arlott simon at arlott.org
Sat Mar 3 21:22:59 CET 2007


Is any part of the patch going to be applied? I mentioned this problem in September last year and it looks like it's existed for years (the semaphore locking did the same thing).

On 24/02/07 19:03, Simon Arlott wrote:
> On 24/02/07 18:48, Andreas Oberritter wrote:
>> Hi Simon,
>>
>> Simon Arlott wrote:
>>> @@ -673,13 +672,8 @@ static int dvb_demux_open(struct inode *
>>>  static int dvb_dmxdev_filter_free(struct dmxdev *dmxdev,
>>>  				  struct dmxdev_filter *dmxdevfilter)
>>>  {
>>> -	if (mutex_lock_interruptible(&dmxdev->mutex))
>>> -		return -ERESTARTSYS;
>>> -
>>> -	if (mutex_lock_interruptible(&dmxdevfilter->mutex)) {
>>> -		mutex_unlock(&dmxdev->mutex);
>>> -		return -ERESTARTSYS;
>>> -	}
>>> +	mutex_lock(&dmxdev->mutex);
>>> +	mutex_lock_interruptible(&dmxdevfilter->mutex);
>> Assuming that the rest of the patch is OK, shouldn't this be a
>> mutex_lock(), too, if the return value will be ignored?
> 
> Argh. Sorry, I accidentally reverted my changes and quickly went through them all again so yes, it should have been mutex_lock(). I should now change that on my running copy... which has somehow kept working.
> 
>> Regards,
>> Andreas

-- 
Simon Arlott

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 829 bytes
Desc: OpenPGP digital signature
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20070303/a0ec59a0/signature.pgp


More information about the linux-dvb mailing list