[linux-dvb] [PATCH] v4l-dvb: add $DESTDIR support

Trent Piepho xyzzy at speakeasy.org
Fri Mar 9 23:08:27 CET 2007


On Fri, 9 Mar 2007, Ludwig Nussel wrote:
> > > > This doesn't seem correct.  Shouldn't it be:
> > > > print OUT "\t/sbin/depmod -a \$(KERNELRELEASE) \$(if \$(DESTDIR),-b \$(DESTDIR))\n\n";
> > >
> > > One needs to run depmod when the modules get installed to their final location.
> > > $DESTDIR is incomplete so it doesn't make sense to run depmod here already.
> >
> > When compiling an RPM package DESTDIR may not be the final location, but
> > that is not the only reason one might want to use DESTDIR.  One could
> > repair a mounted root fs after booting from a rescue CD or be trying to
> > create a bootable MythTV image.

Also consider what would happen if someone tried to rebuild the rpm as root
or another user who would write to /.  The modules would be installed in
the rpm buildroot, but depmod would be run on their system modules.  If the
kernel v4l-dvb is being built against isn't the one that is being run, then
they'll get a new directory in /lib/modules when they build the rpm.

>
> Well, obviously noone cared about such exotic use cased yet. Anyways here a
> patch that adds your change as well, please apply.

Patch applied.



More information about the linux-dvb mailing list