[linux-dvb] [PATCH] m920x for LifeView TV Walker Twin

Aapo Tahkola aet at rasterburn.org
Tue Mar 20 16:03:58 CET 2007


On Wed, 21 Mar 2007 00:33:46 +1100
Nick Andrew <nick-linuxtv at nick-andrew.net> wrote:

> Here's my patch so far.
> 
> Two remaining problems:
> 
> 
> 1 - device is probed twice and I end up with 4 /dev/dvb adapters
> rather than two. The reason is that the USB configuration defines
> two interfaces, so the probe function is called once for each
> interface.
> 
> I don't yet know what to do about this. Presumably the right
> solution is to configure tuner/demod 0 on the first call to
> m920x_probe(), and tuner/demod 1 on the second call. But I don't
> know how to achieve this because all the configuring happens inside
> dvb_usb_device_init() and it's mostly hardcoded inside the @adapter
> array in dvb_usb_device_properties.
> 
> I wrote a quick workaround (which _isn't_ in this patch) which
> detects if it is probing bInterface == 1, and if so then returns
> without probing, and that proves my analysis (only 2 adapters
> are created under /dev/dvb).
> 
> 
> 2 - I haven't been able to stream anything with 'dvbstream',
> although kaffeine works fine. I expect this is not going to
> prevent acceptance of my patch.
> 
> 
> description:
> m920x: add support for LifeView TV Walker Twin
> 
> From: Nick Andrew <nick at nick-andrew.net>
> 
> Add support for "LifeView TV Walker Twin" (USB IDs 10fd:0514,
> 10fd:0513)
> 
> Signed-off-by: Nick Andrew <nick at nick-andrew.net>
> 
> Nick.

Nice job!

Signed-off-by: Aapo Tahkola <aet at rasterburn.org>

Add comments to describe different sticks rc return values.
These might conflict with future hardware.

Signed-off-by: Aapo Tahkola <aet at rasterburn.org>

-- 
Aapo Tahkola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lifeview-rc-comment.patch
Type: text/x-patch
Size: 1112 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20070320/67e4acb0/lifeview-rc-comment.bin


More information about the linux-dvb mailing list