[linux-dvb] [PATCH] m920x for LifeView TV Walker Twin

Nick Andrew nick-linuxtv at nick-andrew.net
Tue Mar 20 21:50:51 CET 2007


I'll update my patch per your comments and post it again soon.

On Tue, Mar 20, 2007 at 10:46:05AM -0400, Michael Krufky wrote:
> ^^^ I dont like this.  There is nothing wrong with it, persay, but I'd like to
> think that there could be a better, cleaner way.  I should have more time later
> on for a more thorough review.  If I can think of something better, I'll make
> suggestions.

Since we now have to cater for different initialisation sequences for
different devices I wanted to make that configuration-driven rather
than code-driven. I didn't want to change struct dvb_usb_device_properties
so adding an argument to m9206_init() looked good.

> ^^^^ I've been meaning to change this, myself.  Something more appropriate would
> be as simple as:
> 
>   +MODULE_DESCRIPTION("DVB Driver for ULI M920x");
> 
> The driver is not specific to MSI Megasky / Digivox / Lifeview -- we might see
> more vendors using these chips in future products, and since it has a pid
> filter, it may be used in usb1.1 or usb 2.0.

I agree; I was just following the style which seemed established, except
putting ULi M920x first. I just found out last night the device will
work on usb1.1 (as you said with the pid filter) and the specific
devices supported by the driver can be found by reading code and
checking USB device IDs.

Nick.



More information about the linux-dvb mailing list