[linux-dvb]
Re: [RFC/PATCHES] xc3028 hybrid tuner, em28xx/em2880-dvb,
saa7134, cx88
Markus Rechberger
mrechberger at gmail.com
Tue May 15 01:13:33 CEST 2007
On 5/15/07, Markus Rechberger <mrechberger at gmail.com> wrote:
> On 5/14/07, Trent Piepho <xyzzy at speakeasy.org> wrote:
> > On Mon, 14 May 2007, Markus Rechberger wrote:
> > > Hi all,
> > >
> > > I exported the patches of my v4l-dvb-experimental repository against
> > > the current v4l-dvb repository on linuxtv.org.
> > >
> > > The single patchfiles are available on mcentral.de
> > > http://mcentral.de/~mrec/patches/v4l-dvb/
> > [93 patches]
> >
> > It's really hard for anyone to make sense of a patch bomb like this.
> > There's just too many changes, and none of the patches even have comments
> > longer than one line.
> >
> > The organization of the patches is really hard to follow too. For
> example,
> > patch 19 adds a NULL pointer check to tuner-core (why is this necessary?)
>
> if the struct is initialized as NULL it won't be possible to access
> the member of it without crashing the kernel.
>
> > and then also adds two register names names to the dvb zl10353 driver.
> > Those changes have nothing to do with each other. It's patch 20 that
> > actually adds the code to zl10353 that uses the new registers, and it even
> > changes the names used in patch 19.
> >
>
> I see the order is a problem there, I've redone the whole tree 3 times
> because of problems with some folks on the ML earlier since I wanted
> to keep the extra changes as small as possible I merged some patches
> finally.
>
> As from my side I don't have the time to do a major rewrite or doing
> some reordering again, please try to make the best out of what's
> available now.
>
> The patches include more than 9000 lines of codechanges through the
> v4l and dvb framework, these changes have been done during the last 1
> 1/2 years of split development from the main v4l-dvb code, I know it's
> alot but it's worth to get it done now. It's not only about adding
> support for one new device only.
to be more accurate where all the changes happened:
b/linux/drivers/media/tuners/Kconfig | 14
b/linux/drivers/media/tuners/Makefile | 7
b/linux/drivers/media/tuners/xc3028-tuner.c | 601 ++++
b/linux/drivers/media/tuners/xc3028-tuner.h | 20
b/linux/drivers/media/video/em28xx/em2880-dvb.c | 748 ++++
b/linux/drivers/media/video/em28xx/em28xx-audio.c | 439 ++
b/linux/drivers/media/video/em28xx/em28xx-webcam.c | 365 ++
b/linux/include/media/v4l_dvb_tuner.h | 131
linux/Documentation/video4linux/CARDLIST.cx88 | 3
linux/Documentation/video4linux/CARDLIST.em28xx | 69
linux/Documentation/video4linux/CARDLIST.tuner | 1
linux/drivers/media/Kconfig | 2
linux/drivers/media/Makefile | 1
linux/drivers/media/common/ir-keymaps.c | 221 +
linux/drivers/media/dvb/b2c2/flexcop-fe-tuner.c | 21
linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c | 34
linux/drivers/media/dvb/dvb-core/dmxdev.c | 6
linux/drivers/media/dvb/dvb-core/dmxdev.h | 1
linux/drivers/media/dvb/dvb-core/dvb_demux.c | 3
linux/drivers/media/dvb/dvb-core/dvb_demux.h | 3
linux/drivers/media/dvb/dvb-core/dvb_frontend.c | 29
linux/drivers/media/dvb/dvb-core/dvb_frontend.h | 64
linux/drivers/media/dvb/dvb-core/dvb_net.c | 29
linux/drivers/media/dvb/dvb-core/dvb_net.h | 1
linux/drivers/media/dvb/dvb-usb/af9005-fe.c | 12
linux/drivers/media/dvb/dvb-usb/au6610.c | 3
linux/drivers/media/dvb/dvb-usb/cxusb.c | 150
linux/drivers/media/dvb/dvb-usb/cxusb.h | 2
linux/drivers/media/dvb/dvb-usb/dib0700_devices.c | 7
linux/drivers/media/dvb/dvb-usb/dibusb-common.c | 6
linux/drivers/media/dvb/dvb-usb/dibusb-mb.c | 17
linux/drivers/media/dvb/dvb-usb/digitv.c | 7
linux/drivers/media/dvb/dvb-usb/dvb-usb-i2c.c | 11
linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h | 2
linux/drivers/media/dvb/dvb-usb/dvb-usb.h | 8
linux/drivers/media/dvb/dvb-usb/gl861.c | 3
linux/drivers/media/dvb/dvb-usb/m920x.c | 14
linux/drivers/media/dvb/dvb-usb/opera1.c | 3
linux/drivers/media/dvb/dvb-usb/ttusb2.c | 3
linux/drivers/media/dvb/dvb-usb/umt-010.c | 3
linux/drivers/media/dvb/frontends/at76c651.c | 2
linux/drivers/media/dvb/frontends/bsbe1.h | 3
linux/drivers/media/dvb/frontends/bsru6.h | 3
linux/drivers/media/dvb/frontends/cx22700.c | 2
linux/drivers/media/dvb/frontends/cx22702.c | 2
linux/drivers/media/dvb/frontends/cx24110.c | 2
linux/drivers/media/dvb/frontends/dib3000mb.c | 2
linux/drivers/media/dvb/frontends/dib3000mc.c | 2
linux/drivers/media/dvb/frontends/dib7000m.c | 2
linux/drivers/media/dvb/frontends/dib7000p.c | 2
linux/drivers/media/dvb/frontends/dvb-pll.c | 65
linux/drivers/media/dvb/frontends/dvb-pll.h | 19
linux/drivers/media/dvb/frontends/dvb_dummy_fe.c | 2
linux/drivers/media/dvb/frontends/l64781.c | 2
linux/drivers/media/dvb/frontends/lgdt330x.c | 6
linux/drivers/media/dvb/frontends/mt2060.c | 43
linux/drivers/media/dvb/frontends/mt2060.h | 6
linux/drivers/media/dvb/frontends/mt312.c | 2
linux/drivers/media/dvb/frontends/mt352.c | 15
linux/drivers/media/dvb/frontends/mt352.h | 3
linux/drivers/media/dvb/frontends/nxt200x.c | 2
linux/drivers/media/dvb/frontends/nxt6000.c | 2
linux/drivers/media/dvb/frontends/or51132.c | 2
linux/drivers/media/dvb/frontends/qt1010.c | 59
linux/drivers/media/dvb/frontends/qt1010.h | 4
linux/drivers/media/dvb/frontends/s5h1420.c | 6
linux/drivers/media/dvb/frontends/sp8870.c | 2
linux/drivers/media/dvb/frontends/sp887x.c | 4
linux/drivers/media/dvb/frontends/stv0297.c | 2
linux/drivers/media/dvb/frontends/stv0299.c | 4
linux/drivers/media/dvb/frontends/tda10021.c | 2
linux/drivers/media/dvb/frontends/tda10023.c | 2
linux/drivers/media/dvb/frontends/tda1004x.c | 2
linux/drivers/media/dvb/frontends/tda10086.c | 4
linux/drivers/media/dvb/frontends/tda8083.c | 2
linux/drivers/media/dvb/frontends/tda80xx.c | 2
linux/drivers/media/dvb/frontends/tda826x.c | 21
linux/drivers/media/dvb/frontends/tda826x.h | 4
linux/drivers/media/dvb/frontends/tda827x.c | 88
linux/drivers/media/dvb/frontends/tda827x.h | 4
linux/drivers/media/dvb/frontends/tua6100.c | 33
linux/drivers/media/dvb/frontends/tua6100.h | 4
linux/drivers/media/dvb/frontends/ves1820.c | 2
linux/drivers/media/dvb/frontends/ves1x93.c | 2
linux/drivers/media/dvb/frontends/zl10353.c | 24
linux/drivers/media/dvb/frontends/zl10353.h | 7
linux/drivers/media/dvb/frontends/zl10353_priv.h | 2
linux/drivers/media/dvb/pluto2/pluto2.c | 7
linux/drivers/media/dvb/ttpci/av7110.c | 50
linux/drivers/media/dvb/ttpci/budget-av.c | 32
linux/drivers/media/dvb/ttpci/budget-ci.c | 22
linux/drivers/media/dvb/ttpci/budget-patch.c | 10
linux/drivers/media/dvb/ttpci/budget.c | 28
linux/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c | 35
linux/drivers/media/video/cx88/cx88-cards.c | 105
linux/drivers/media/video/cx88/cx88-dvb.c | 51
linux/drivers/media/video/cx88/cx88-i2c.c | 72
linux/drivers/media/video/cx88/cx88.h | 5
linux/drivers/media/video/em28xx/Kconfig | 29
linux/drivers/media/video/em28xx/Makefile | 6
linux/drivers/media/video/em28xx/em28xx-cards.c | 1898 +++++++++++-
linux/drivers/media/video/em28xx/em28xx-core.c | 773 +++--
linux/drivers/media/video/em28xx/em28xx-i2c.c | 344 ++
linux/drivers/media/video/em28xx/em28xx-input.c | 158 +
linux/drivers/media/video/em28xx/em28xx-video.c | 2402 ++++++++++++----
linux/drivers/media/video/em28xx/em28xx.h | 552 ++-
linux/drivers/media/video/saa7134/saa7134-cards.c | 85
linux/drivers/media/video/saa7134/saa7134-dvb.c | 67
linux/drivers/media/video/saa7134/saa7134-i2c.c | 44
linux/drivers/media/video/saa7134/saa7134.h | 4
linux/drivers/media/video/tuner-core.c | 171 +
linux/drivers/media/video/tveeprom.c | 2
linux/include/media/ir-common.h | 6
linux/include/media/tuner.h | 7
linux/include/media/v4l2-common.h | 2
v4l/Makefile | 4
v4l/scripts/cardlist | 1
v4l/scripts/em28xx.pl | 97
v4l/scripts/gentree.pl | 1
v4l/scripts/tuner.pl | 3
120 files changed, 9118 insertions(+), 1496 deletions(-)
Markus
More information about the linux-dvb
mailing list