[linux-dvb] DVB-S2 API vs. HVR4000: When?

Steven Toth stoth at linuxtv.org
Fri Nov 2 20:10:44 CET 2007


Steven Toth wrote:
> Manu Abraham wrote:
>> Steven Toth wrote:
>>  
>>> Manu Abraham wrote:
>>>    
>>>> Steven Toth wrote:
>>>>  
>>>>      
>>>>> simpler/smaller interface. I made reference to this in my first 
>>>>> HVR4000
>>>>> patches where massive amounts of code were potentially being 
>>>>> duplicated.
>>>>>             
>>>> Please point out the duplication.
>>>>
>>>>         
>>> At the time, the demod drivers had to provide a set_frontend() and
>>> set_params() ops method. That meant two entry points into every driver
>>> (with differing args), the same was true for many other entry points
>>> that took the new structures.
>>>     
>>
>> Btw, before you start complaining about other's code, It is always 
>> better to have a look at your own code to have a feel where you are 
>> standing.
>>
>> Because of some of your changes we have had long arguments by Markus,
>> (on locking) well this was in kernel. What you are complaining is 
>> something not even applied to the kernel and very much pre alpha.
>>
>> Just to talk back on the same tongue.
>>
>>   
>
> You asked for my feedback. So, I gave you all the feedback based on 
> the last time I reviewed your code, I even said that these issue may 
> already be fixed. (Explicitly opening myself up for attack - should 
> you chose). This review took place prior to you removing it from 
> LinuxTV and you doing your own thing.
>
> Why are we arguing Manu when we both want the same thing to happen, 
> for multiproto to get traction?
>
> Have I not always been polite in all of my offers of help, prior to my 
> recent bitterness and/or sarcasm?
>
> Look at the situation from an outsiders perspective. Whenever the 
> subject of finishing the multiproto work comes up, the conversation 
> never ends in a happy place.
>
> I keep repeating myself when I'm say this: Nothing would make me 
> happier than seeing multiproto in a test tree, where people inside 
> (and outside) of the LinuxTV team can contribute. It would be a 
> significant step forward but whenever this subject is raised, 
> regardless of how politely I try to ask, it never results in a good 
> conversation.
>
> I wish we could find a better way to communicate (and/or work 
> together), for the good of everyone.
>
> - Steve
>
>
>
Resend.




More information about the linux-dvb mailing list