[linux-dvb] [RFC-final] videobuf tree

Michael Krufky mkrufky at linuxtv.org
Mon Oct 8 14:29:08 CEST 2007


Mauro Carvalho Chehab wrote:
> Michael,
>
>
>   
>> However, cx23885 is now broken.  Upon starting a DVB stream, the
>> following OOPS is generated:
>>     
>
> I've reviewed cx23885 videobuf stuff. I noticed a problem at the
> conversions: It is still using the abstract videobuf constructor,
> instead of the pci DMA S/G one. I've just added a patch fixing this at
> v4l-dvb tree. Probably, this will fix the issue.

Mauro,

This new patch fixed the problem.  CX23885 functionality is restored!  :-)

side note:  If we had left a single header, video-buf.h, we could have
avoided this problem.  When we rename files like this, we run the risk
of building against the wrong headers, if errors are not caught &
corrected quickly enough.

Are you open to merging the videobuf-*.h into a single video-buf.h
header file, to match the filename in previous kernel versions so that
we can avoid this issue from recurring?  Either that, or including the
current headers into a new video-buf.h would do the same job.

What do you think?

-Mike



More information about the linux-dvb mailing list