[linux-dvb] [Patch] saa7134: fix NULL dereference at suspend time for cards without IR receiver

Matthias Schwarzott zzam at gentoo.org
Thu Oct 18 13:41:20 CEST 2007


Hi there!

I played around with some new (not supported) card based on saa7134
(Avermedia dvb-s pro A700).
This lead to suspend crashing when saa7134 module was loaded.

Reason is: saa7134_suspend unconditionally calls  saa7134_ir_stop:

void saa7134_ir_stop(struct saa7134_dev *dev)
{
        if (dev->remote->polling)
                del_timer_sync(&dev->remote->timer);
}

So this must fail if dev->remote is NULL. cx88 driver seems to have the same 
layout, but this one already has the NULL-check implemented.

This patch now checks dev->remote before calling saa7134_ir_stop.

Matthias
-- 
Matthias Schwarzott (zzam)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: saa7134-suspend-ir-fix.diff
Type: text/x-diff
Size: 815 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20071018/a29f1392/attachment.diff 


More information about the linux-dvb mailing list