[linux-dvb] TT S-1401 problem with kernel 2.6.24 ???

Mauro Carvalho Chehab mchehab at infradead.org
Fri Apr 4 03:29:37 CEST 2008


> > > If we should go back to 2.6.23 level, so far nobody seems to have
> > > realized a improvement for the LifeView Trio stuff, I'm not against it.
> > > 
> > > The changeset in question to revert is mercurial 6579.
> > > 
> > > If nobody else is interested and no comments, I also don't care anymore.
> > 
> > (Basically I don't care because I am tired of discussing kernel
> > politics.)
> > 
> > Imho a fix should be applied, no matter how many lines it has.
> > If that is not possible the offending patch should be reverted in
> > 2.6.24.x.
> > 
> > CU
> > Oliver
> 
> 
> I fully agree!
> 
> But that is exactly where they hang us and I have it totally sick,
> especially in combination with current checkpatch.pl brain damage.

Hmm... I think I missed the point or we are miss-communicating. What
checkpatch.pl has to do with this discussion?

---

Let me try to reset to a sane state.

With the current tree (changesets 6579 and 7186), is there any broken board? If
so, what board(s)?

Both patches are already applied at mainstream and should be available on
2.6.25. Are those OK for 2.6.25?

Is there any missing patch that should be sent to -stable (2.6.24)? If so, what
patch?

---

If there's still a broken card, a fix is as simple as forking flydvbs struct.
We still have time to prepare the fix, test and send to -rc8, once we can
understand what card is broken.

Repeating what I said on my last e-mail: currently, there are several variants
sharing the same properties specified on flydvbs struct:
	SAA7134_BOARD_FLYDVB_TRIO,
	SAA7134_BOARD_MEDION_MD8800_QUADRO,
	SAA7134_BOARD_FLYDVBS_LR300,
	SAA7134_BOARD_PHILIPS_SNAKE,
	SAA7134_BOARD_MD7134_BRIDGE_2.

If one of more of those boards are broken, it is just a matter of doing a very
trivial patch like the one bellow, to the offended cards:

diff -r 1abbd650fe07 linux/drivers/media/video/saa7134/saa7134-dvb.c
--- a/linux/drivers/media/video/saa7134/saa7134-dvb.c	Thu Apr 03 17:08:04 2008 -0300
+++ b/linux/drivers/media/video/saa7134/saa7134-dvb.c	Thu Apr 03 22:26:03 2008 -0300
@@ -854,6 +854,12 @@ static struct tda10086_config flydvbs = 
 	.diseqc_tone = 0,
 };
 
+static struct tda10086_config flydvbs_2 = {
+	.demod_address = 0x0e,
+	.invert = 0,
+	.diseqc_tone = 1,
+};
+
 /* ------------------------------------------------------------------
  * special case: lnb supply is connected to the gated i2c
  */
@@ -1071,7 +1077,7 @@ static int dvb_init(struct saa7134_dev *
 			configure_tda827x_fe(dev, &md8800_dvbt_config, &tda827x_cfg_0);
 		} else {        /* satellite */
 			dev->dvb.frontend = dvb_attach(tda10086_attach,
-							&flydvbs, &dev->i2c_adap);
+							&flydvbs_2, &dev->i2c_adap);
 			if (dev->dvb.frontend) {
 				struct dvb_frontend *fe = dev->dvb.frontend;
 				u8 dev_id = dev->eedata[2];

We _just_ need to know what cards are reported to have Diseqc broken. This
patch can arrive kernel in time for 2.6.25.

Cheers,
Mauro



More information about the linux-dvb mailing list