[linux-dvb] [PATCH] DViCO FusionHDTV DVB-T Dual Digital 4 (rev 2)
mkrufky at linuxtv.org
Sun Aug 10 19:54:57 CEST 2008
Anton Blanchard wrote:
> Add support for revision 2 of the DViCO FusionHDTV DVB-T Dual Digital 4
> which has new tuners and demodulators (2 x DIB7070p). With this patch
> both DVB reception and IR works.
> The dib7000p driver currently hardwires the output mode to
> OUTMODE_MPEG2_SERIAL regardless of what we ask for. Modify it to allow
> OUTMODE_MPEG2_PAR_GATED_CLK to be set. Longer term we should remove the
> check completely and set the output mode correctly in all the callers.
> Add Kconfig bits to ensure the dib7000p and dib0070 modules are enabled.
> It would be nice to only do this for the !DVB_FE_CUSTOMISE case, but
> this is what the other DIB7070 module does (there are a number of
> module dependencies in the attach code).
> Signed-off-by: Anton Blanchard <anton at samba.org>
I've applied your patch to my cxusb tree, with slight modifications.
Please test the tree and confirm proper operation before I request a
merge into the master branch.
You'll notice that I fixed the dib0070.h and dib7000p.h headers to allow
cxusb the option of using DVB_FE_CUSTOMIZE, but when these modules are
selected, dvb-usb-cxusb is still static linked to them.
Perhaps we could put all of the dib7070p common setup into a dib7070p
module, to centralize the duplicated code between dib0700 and cxusb.
This could also help to remove the static links described above.
I started playing around with this idea -- If I make any progress, I'll
post the tree and ask for testers.
I don't think that the static links are enough of a reason to hold this
patch back from a merge. Hopefully we can find a solution before
2.6.28, but if we don't , it's no real harm done.
If you have any additional fixes / changes to make before this is merged
into master, please generate them against this cxusb tree.
More information about the linux-dvb