[linux-dvb] BUG in changeset 7157?

Mauro Carvalho Chehab mchehab at infradead.org
Wed Feb 6 01:49:36 CET 2008


On Tue, 05 Feb 2008 23:44:31 +0100
e9hack <e9hack at googlemail.com> wrote:

> Hi,
> 
> compiling of the current HG tree fails on linux 2.6.24. I think it is a bug in changeset 7157:
> 
> --- a/v4l/compat.h Tue Feb 05 07:37:21 2008 +0000
> +++ b/v4l/compat.h Tue Feb 05 11:21:32 2008 -0200
> @@ -497,6 +497,10 @@ do { \
> #ifndef BIT_MASK
> # define BIT_MASK(nr) (1UL << ((nr) % BITS_PER_LONG))
> # define BIT_WORD(nr) ((nr) / BITS_PER_LONG)
> +
> +#define i2c_verify_client(dev) \
> + ((dev->bus == &i2c_bus_type) ? to_i2c_client(dev) : NULL)
> +
> #endif
> 
> The definition of i2c_verify_client() should not be inside #ifndef BIT_MASK / #endif. The 
> variable i2c_bus_type is only public on 2.6.23.x (maybe also on earlier versions) but not 
> on 2.6.24. The following patch does fix the problem on 2.6.24 for me:

Committed, thanks!

Cheers,
Mauro



More information about the linux-dvb mailing list