[linux-dvb] [BUG] Firmware loading of FF cards is broken

[e9hack]

Hi,

changsets 7973/7958 break the firmware loading of the TT-C2300 card. I get the following 
message:

Linux video capture interface: v2.00
saa7146: register extension 'dvb'.
ACPI: PCI Interrupt 0000:04:06.0[A] -> Link [LNKA] -> GSI 18 (level, low) -> IRQ 21
saa7146: found saa7146 @ mem f98f6c00 (revision 1, irq 21) (0x13c2,0x000a).
dvb-ttpci: crc32 of dpram file does not match.
ACPI: PCI interrupt for device 0000:04:06.0 disabled

It seems, that get_unaligned_be32() is broken. The definition in compat.h is:

#define get_unaligned_be32(a)                                   \
         be32_to_cpu(get_unaligned((unsigned short *)(a)))

'unsigned short *' is wrong. It should be 'unsigned long *'.

put_unaligned_be32(), get_unaligned_le32() and put_unaligned_le32() are also wrong.

-Hartmut