[linux-dvb] [PATCH] Re: Ooops in tda827x.c

Michael Krufky mkrufky at linuxtv.org
Wed Jun 4 15:39:08 CEST 2008


> On Wed, 2008-06-04 at 01:22 +0200, Sigmund Augdal wrote:
>> changeset 49ba58715fe0 (7393) introduces an ooops in tda827x.c in
>> tda827xa_lna_gain. The initialization of the "msg" variable accesses
>> priv->cfg before the NULL check causing an oops when it is in fact
>> NULL.
>>
>> Best regards
>>
>> Sigmund Augdal


2008/6/4 Sigmund Augdal <sigmund at snap.tv>:
> Attached patch fixes the problem.
>
> Best regards
>
> Sigmund Augdal
>


Sigmund,

The driver was only able to get into this function without priv->cfg
being defined, because m920x passes in NULL as cfg.

In my opinion, this is flawed by design, and m920x should pass in an
empty structure rather than a NULL pointer, but I understand why
people might disagree with that.

With that said, your patch looks good and I see that it fixes the
issue. Please provide a sign-off so that your fix can be integrated
and you will receive credit for your work.

Use the form:

Signed-off-by: Your Name <email at addre.ss>

Regards,
Mike



More information about the linux-dvb mailing list