[linux-dvb] Updated Mantis VP-2033 remote control patch for Manu's jusst.de Mantis branch
pauli at borodulin.fi
Mon May 19 18:52:40 CEST 2008
> On 5/17/08, Pauli Borodulin <pauli at borodulin.fi> wrote:
>> Since there has been some direct requests for this via email, I'm
>> posting a updated version of Kristian Slavov's original remote control
>> patch for Manu's jusst.de Mantis branch. The new version is
>> functionally the same as the one I posted in March.
Markus Rechberger wrote:
> +int mantis_rc_exit(struct mantis_pci *mantis)
> + mmwrite(mmread(MANTIS_INT_MASK) & (~MANTIS_INT_IRQ1),
> + cancel_delayed_work(&mantis->ir.rc_query_work);
> + input_unregister_device(mantis->ir.rc_dev);
> + dprintk(verbose, MANTIS_DEBUG, 1, "RC unregistered");
> + return 0;
> this might be dangerous when unloading the driver because the callback
> function might still be running after cancel_delayed_work.
> I ran into that problem a while ago and it could lock up the whole input system.
Thanks Markus! I created a revised version of the patch with call to
flush_scheduled_work() after calling cancel_delayed_work. I also changed
RC polling a bit so that it would work alike on different kernel
configurations (thanks go to Kristian Slavov for pointing this out).
The patch is against
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the linux-dvb