[linux-dvb] [PATCH 1/7] Adding empia base driver

Andy Walls awalls at radix.net
Sat Nov 1 15:36:02 CET 2008


On Sat, 2008-11-01 at 15:05 +0100, Hans Verkuil wrote:

> Hi Markus,
> 
> As promised I've done a review of your empia driver and looked at what 
> needs to be done to get it into the kernel.
> 
> First of all, I've no doubt that your empia driver is better and 
> supports more devices than the current em28xx driver. I also have no 
> problem adding your driver separate from the current driver. It's been 
> done before (certain networking drivers spring to mind) and while 
> obviously not ideal I expect that the older em28xx driver can probably 
> be removed after a year or something like that.

[snip]

> So my recommendation would be to:

[snip]

> 3) Switch to video_ioctl2 in the empia driver. You can do that, but we 
> can probably find a volunteer as well.
> 
> 4) Conform the code to the coding style. If several people can help with 
> this we can get it done pretty quickly.

I can support these two portions of the effort, if what Hans' proposes
is the agreed plan.

Point me to the target directories in the repo, and suggest desired
completion dates for whatever tasks.

Standing by...

Regards,
Andy





More information about the linux-dvb mailing list