[linux-dvb] [PATCH] scan-s2: fixes and diseqc rotor support

Alex Betis alex.betis at gmail.com
Fri Nov 14 09:30:37 CET 2008


On Fri, Nov 14, 2008 at 1:04 AM, Hans Werner <HWerner4 at gmx.de> wrote:

> > Hans,
> > I'm looking on your QPSK diff and I disagree with the changes.
> > I think the concept of having all missing parameters as AUTO values
> should
> > have modulation, rolloff and FEC set to AUTO enumeration.
> > If your card can't handle the AUTO setting, so you have to specify it in
> > the
> > frequency file.
>
> I want the computer to do the work, see below ;).

Ok, I can't disagree with that :)

>
>
> > Applying your changes will break scaning S2 channels for a freq file with
> > the following line:
> > S 11258000 H 27500000
> > or even
> > S2 11258000 H 27500000
> >
> > Since it will order the driver to use QPSK modulation, while there should
> > be
> > 8PSK or AUTO.
> > I don't really know how rolloff=35 will affect since its the default in
> > some
> > drivers, but again, AUTO setting was intended for that purpose,
> > to let the card/driver decide what parameters should be used.
>
> Ok, I have looked at this again and written a new patch. I also looked at
> what
> you checked in yesterday for S1/S2 and -D options.
>
> In order to keep the AUTO behaviour you want and also allow for cards which
> cannot handle autos I have added a new option -X which sets a noauto flag.
> When this option is chosen, instead of putting an initial transponder with
> an AUTO
> in the transponder list, several transponders are created for each allowed
> value of
> each free parameter (which may be delivery system, modulation, fec or
> rolloff).
>
> so with -X
> S 12551500 V 22000000 5/6
> results in
> initial transponder DVB-S  12551500 V 22000000 5/6 35 QPSK
> initial transponder DVB-S2 12551500 V 22000000 5/6 35 QPSK
> initial transponder DVB-S2 12551500 V 22000000 5/6 35 8PSK
> initial transponder DVB-S2 12551500 V 22000000 5/6 25 QPSK
> initial transponder DVB-S2 12551500 V 22000000 5/6 25 8PSK
> initial transponder DVB-S2 12551500 V 22000000 5/6 20 QPSK
> initial transponder DVB-S2 12551500 V 22000000 5/6 20 8PSK
>
> (fec was fixed in the transponder file in this example, but delivery
> system, rolloff and modulation were not)
>
> The new S1/S2 and -D options are respected. So with -D S1, the S2
> lines would not be added for example.
>
> Using -X -D and S2/S1/S thus gives lots of flexibility for scanning.

I hope we won't run out of free letters for next command line flags we'll
add :)
Sounds good to me. My recent changes to delete duplicate frequencies when
lock was successful on one of them will be especially helpful in that case
to speed up the scan process.

>
>
> The patch also makes improvements in
> parse_satellite_delivery_system_descriptor, adding rolloff and the
> new S2 FECs and changes to delivery system and modulation parsing.

Thanks. You did part of the work I've intended to do :)

>
>
> Hans
>
> --
> Release early, release often.
>
> Sensationsangebot nur bis 30.11: GMX FreeDSL - Telefonanschluss + DSL
> für nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K11308T4569a
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.linuxtv.org/pipermail/linux-dvb/attachments/20081114/88978068/attachment.htm 


More information about the linux-dvb mailing list