[linux-dvb] [PATCH] Add missing S2 caps flag to S2API

Klaus Schmidinger Klaus.Schmidinger at cadsoft.de
Tue Nov 25 09:35:26 CET 2008


On 24.11.2008 20:33, Manu Abraham wrote:
> Klaus Schmidinger wrote:
>> On 24.11.2008 16:55, Niels Wagenaar wrote:
>>> ...
>>> For the time being I have only two options which will work without any
>>> additional patching in S2API:
>>>
>>> - Let the user set this as an option
>>> - Use my VUP (very ugly patch) by checking the deliverystem for the string
>>> "DVBS2".
>> Both are ugly workarounds and any reasonable API requiring them instead
>> of simply reporting the -S2 capability of a device should
>> be ashamed, go home and do its homework.
> 
> ACK
> 
>> For the time being I'll work with my suggested FE_CAN_2ND_GEN_MODULATION
>> patch - until somebody can suggest a different way of doing this (without
>> parsing strings or requiring the user to do it).
> 
> ACK.
> 
> That is a saner way of doing it rather than anything else, as it stands.
> 
> Anyway, we won't be seeing professional device support as it stands with
> the current API anytime soon, so as it stands the better alternative is
> thus.
> 
> But it would be nice to have something shorter: say FE_IS_2G or
> something that way, for the minimal typing.

Well, I don't really care about the actual name - as long as I can
get the information... ;-)

Klaus



More information about the linux-dvb mailing list