[linux-dvb] [PATCH] [resent] cx88-dvb: Fix Oops in case i2c bus failed to register

Darron Broad darron at kewl.org
Fri Oct 24 19:25:44 CEST 2008


In message <200810241916.54137.zzam at gentoo.org>, Matthias Schwarzott wrote:

hi.

>On Freitag, 24. Oktober 2008, Darron Broad wrote:
>> In message <200810241247.08480.zzam at gentoo.org>, Matthias Schwarzott wrote:
>>
>> Hiya.
>>
>> >Hi!
>> >
>> >@Mauro: Please pull this patch
>> >There already is an report at kernel bugzilla about this issue:
>> >http://bugzilla.kernel.org/show_bug.cgi?id=9455
>> >
>> >When enabling extra checks for the i2c-bus of cx88 based cards by
>> >loading i2c_algo_bit with bit_test=1 this may trigger an oops
>> >when loading cx88_dvb.
>> >
>> >This is caused by the extra check code that detects that the
>> >sda-line is stuck high and thus does not register the i2c-bus.
>> >
>> >cx88-dvb however does not check if the i2c-bus is valid and just
>> >uses core->i2c_adap to attach dvb frontend modules.
>> >This leads to an oops at the first call to i2c_transfer:
>> >
>> ># modprobe i2c_algo_bit bit_test=1
>> ># modprobe cx8802
>>
>> Thanks for this information. If you don't mind, would you let
>> me utilise this fix in another way?
>>
>> I have been auditing MFE additions and I need to change
>> something elsewhere and can see an alternative to
>> to bailing out in dvb_register?
>>
>> Thanks
>
>I think Mauro already applied it, but well, if you want it in another place, 
>the check could also be placed in cx8802_dvb_probe around the line where 
>vp3054_i2c_probe is called.

Yes, that is where I have put it on my local clean-ups and fixes just
above that detection.

I have lots of stuff which is work in progress which will be ready soon.

Thanks.

--

 // /
{:)==={ Darron Broad <darron at kewl.org>
 \\ \ 




More information about the linux-dvb mailing list