[linux-dvb] [PATCH] Support faulty USB IDs on DIBUSB_MC

Devin Heitmueller devin.heitmueller at gmail.com
Mon Feb 9 21:32:41 CET 2009


On Mon, Feb 9, 2009 at 3:16 PM, matthieu castet <castet.matthieu at free.fr> wrote:
> Devin Heitmueller wrote:
>> On Mon, Feb 9, 2009 at 2:40 PM, matthieu castet <castet.matthieu at free.fr> wrote:
>>> Hi,
>>>
>>> matthieu castet wrote:
>>>> matthieu castet wrote:
>>>>> Hi Patrick,
>>>>>
>>>>> Patrick Boettcher wrote:
>>>>>> Hi,
>>>>>>
>>
>> The assumption that you can only have write/read or write requests is
>> one of the big things fixed in the 1.20 firmware.  If you are running
>> the 1.20 firmware, you just need to add the option to use the new i2c
>> function instead of the legacy i2c transfer function.
> Unfortunamty this is for dib0700 and not dib3000.
> dib3000 doesn't got new firmware/i2c API.
>
> But the same patch should be done for dib0700_i2c_xfer_legacy...

Wow, I totally overlooked that your patch was against dibusb-common.c
instead of dib0700_core.c.  Yes, you are correct then.  However I
would still suggest sending an error to the console and returning
failure rather than just silently dropping the i2c read request.

Cheers,

Devin

-- 
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller



More information about the linux-dvb mailing list