[linux-dvb] TechnoTrend C-1501 - Locking issues on 388Mhz

hermann pitton hermann-pitton at arcor.de
Fri Mar 27 02:39:07 CET 2009


Am Donnerstag, den 26.03.2009, 22:02 -0300 schrieb Mauro Carvalho
Chehab:
> On Fri, 27 Mar 2009 01:46:50 +0100
> hermann pitton <hermann-pitton at arcor.de> wrote:
> 
> > 
> > Am Donnerstag, den 26.03.2009, 21:09 -0300 schrieb Mauro Carvalho
> > Chehab:
> > > On Fri, 27 Mar 2009 00:51:43 +0100
> > > hermann pitton <hermann-pitton at arcor.de> wrote:
> > > 
> > > > Hi Klaas,
> > > > 
> > > > Am Mittwoch, den 25.03.2009, 21:53 +0100 schrieb klaas de waal:
> > > > > (2nd try, this should be now  in "plain text" instead of HTML)
> > > > > 
> > > > > Hi Hermann,
> > > > > 
> > > > > Thanks for your "howto" on making a proper patch.
> > > > > After a "make commit" in my local v4l-dvb tree, and filling in the
> > > > > template I got the following output.
> > > > > I confess I do not know if this has now ended up somewhere in
> > > > > linuxtv.org or that it is just local.
> > > > > However, here it is:
> > > > 
> > > > your patches are still local, but they are at least on the proper list
> > > > now. Without starting with [PATCH] in the subject Mauro's scripts to add
> > > > them to patchwork automatically likely will still not find them.
> > > 
> > > The patchwork scripts are the ones that came with the product. They are not
> > > developed by me ;)
> > > 
> > > Anyway, if patchwork didn't catch is because the inlined patch is broken, or it is
> > > not inlined and were attached with a wrong mime type.
> > > 
> > 
> > Oh well, I still would prefer to have comments from such closest to that
> > driver and related tuners, instead serving that "product".
> > 
> > There is more drifting around and it can be prepared to fit in to such
> > rules. My concern is that it will arrive there then without much
> > problems, but outstanding discussions are only postponed.
> > 
> > If I'm wrong, even better.
> 
> The point is that sending a broken patch won't work, anyway, since they can't
> be applied. The advantage of the tool is that it is clear to everyone that the
> patch is ok (so, patchwork picked), or if it is line-wrapped or is not inlined,
> creating troubles for people to review and apply.

Mauro, that is acceptable for me.

It loads work off from you and others and within the flood of patches we
see that is OK. To talk others to that to follow such rules is a great
annoyance and I ended up several times without further replies.

But my main concern is, if it once arrived at patchwork formally, it is
out of sight for most of us and might miss proper review, except you are
sure you can always guarantee that. I don't want to start to argue about
all what happened in the past.

So, at least, if some patch arrived there mysteriously ;), the
linux-media list should be informed that it is there now and last time
to speak off, in case anything is not fully clear, before vanishing into
some black hole until you find it in the next kernel release ...

Cheers,
Hermann







More information about the linux-dvb mailing list