[linux-dvb] TechnoTrend C-1501 - Locking issues on 388Mhz

hermann pitton hermann-pitton at arcor.de
Sat Mar 28 06:51:40 CET 2009


Am Samstag, den 28.03.2009, 05:48 +0100 schrieb hermann pitton:
> Am Samstag, den 28.03.2009, 05:32 +0100 schrieb hermann pitton:
> > Am Samstag, den 28.03.2009, 00:58 -0300 schrieb Mauro Carvalho Chehab:
> > > On Sat, 28 Mar 2009 00:23:55 +0100
> > > hermann pitton <hermann-pitton at arcor.de> wrote:
> > > 
> > > > Hi,
> > > > 
> > > > Am Freitag, den 27.03.2009, 07:38 -0300 schrieb Mauro Carvalho Chehab:
> > > > > On Fri, 27 Mar 2009 02:39:07 +0100
> > > > > hermann pitton <hermann-pitton at arcor.de> wrote:
> > > > > 
> > > > > > But my main concern is, if it once arrived at patchwork formally, it is
> > > > > > out of sight for most of us and might miss proper review, except you are
> > > > > > sure you can always guarantee that. I don't want to start to argue about
> > > > > > all what happened in the past.
> > > > > > 
> > > > > > So, at least, if some patch arrived there mysteriously ;), the
> > > > > > linux-media list should be informed that it is there now and last time
> > > > > > to speak off, in case anything is not fully clear, before vanishing into
> > > > > > some black hole until you find it in the next kernel release ...
> > > > > 
> > > > > The only way to send patches to patchwork is to submit it via linux-media list.
> > > > > There's no other way. So, all patch discussions and reviews should happen at
> > > > > the ML, by replying at the patch email (or by replying another reply).
> > > > > Patchwork will keep track of such replies as well.
> > > > > 
> > > > 
> > > > What happened so far with this patches is quite funny,
> > > > for me some black hole seems to be involved.
> > > > 
> > > > Klaas did send them the first time, also directly to me, on Tue, 24 Mar
> > > > 2009 23:14:11 +0100.
> > > > 
> > > > Now I can see you have pulled them in already on Wednesday.
> > > > http://linuxtv.org/hg/v4l-dvb/rev/5efa9fbc8a88
> > > > 
> > > > There is no trace anymore on patchwork visible to me.
> > > > http://patchwork.kernel.org/project/linux-media/list
> > > > So I don't know how you processed them.
> > > 
> > > The above link uses the default patchwork filtering. By default it shows only
> > > patches where there's an action required (e. g. New or Under Review patches).
> > > 
> > > To view a full list of the patches, you need to click at filters and select any.
> > > 
> > > You'll see all patches:
> > > 	http://patchwork.kernel.org/project/linux-media/list/?state=*
> > > 
> > > In the specific case od Klaas, this is his patch:
> > > 
> > > http://patchwork.kernel.org/patch/14405/
> > > 
> > > > Most confusing is, that Klaas obviously did not receive a mail
> > > > notification from linuxtv-commits that his patch came in.
> > > 
> > > > 
> > > > Last message date: Fri Feb 15 19:45:02 CET 2008
> > > > Archived on: Fri Feb 15 19:45:04 CET 2008 
> > > > 
> > > > Is it broken or only the archive not up to date?
> > > > 
> > > 
> > > I've received the notification here:
> > > 
> > > From: Patch from klaas de waal  <hg-commit at linuxtv.org>
> > > To: linuxtv-commits at linuxtv.org
> > > Cc: , Mauro Carvalho Chehab <mchehab at redhat.com>, klaas de waal <klaas.de.waal at gmail.com>
> > > Subject: [linuxtv-commits] [hg:v4l-dvb] tda827x: fix locking issues with DVB-C
> > > Date: Fri, 27 Mar 2009 18:05:01 +0100
> > > Reply-To: klaas de waal via Mercurial <klaas.de.waal at gmail.com>
> > > Sender: linuxtv-commits-bounces at linuxtv.org
> > > 
> > > The patch number 11236 was added via Mauro Carvalho Chehab <mchehab at redhat.com>
> > > to http://linuxtv.org/hg/v4l-dvb master development tree.
> > > 
> > > Klaas should be received this also. Maybe some anti-spam filtering on his side?
> > > 
> > > You'll probably see this also at the linuxtv-commits archives.
> > > 
> > > > Why else he would have posted a second time on
> > > > Wed, 25 Mar 2009 21:53:02 +0100 not knowing anything about the status of
> > > > his patches, which made me believe I should try to help him?
> > > > 
> > > > The timestamp on your mercurial commit of them is
> > > > Wed Mar 25 20:53:02 2009 +0000 (2 days ago)
> > > > That is the time when his second email arrived converted to Greenwich
> > > > time? Or how could you commit within the same second that mail arrived?
> > > 
> > > > This is the time the patches have on both of his original mails.
> > > > --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
> > > > --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
> > > 
> > > The import scripts will try to preserve the original date of the sent email.
> > > 
> > > So, the date there is when the code were presented to public.
> > > 
> > > > How can I ever know when they were really added and if they went through
> > > > patchwork :)
> > > > 
> > > > I was just about to suggest Klaas should try again with [PATCH] in the
> > > > subject until they are listed at patchwork.
> > > 
> > > If the patch was received by patchwork, and "disappeared", all you need to do
> > > is to click on filter and select a proper filter, like:
> > > 
> > > http://patchwork.kernel.org/project/linux-media/list/?submitter=klaas&state=*
> > > 
> > > This will present all patches authored by "klaas", and their state. Ah, if you
> > > click on the patch, you'll see all the patch history, including the
> > > sent/received emails. Even this email should be added there by patchwork ;)
> > > 
> > > Cheers,
> > > Mauro
> > 
> > Mauro, you are joking.
> > 
> > How I ever could come to that from here?
> > http://patchwork.kernel.org/project/linux-media/list
> > 
> > I'm forced to read the source code.
> > 
> > There seems to be some serious utf8 bug too.
> 
> Ok, I can see now you can click at least one of the 2mm buttons, of
> course all self explaining :)

One last comment on it, hopefully all goes well, but it did not go like
I would have preferred it.

It was not waited for, if somebody has eventually already the detailed
programming instructions for that one. It likely is the case after all
these years.

The patch was never tested by those eventually affected on the other
side, since at least I would have await that this direction is confirmed
to still be right previously :)

The driver maintainer, who has also high credits for moderating within
unrelated conflicting stuff he did not cause at all over years, did not
give a statement yet. My, wait at least a week after the patches are
around since ever anyway, except for getting the LNA config quiet.

Cheers,
Hermann









More information about the linux-dvb mailing list