[mpeg2] Re: Porting kfir for kernel 2.6

[Anssi Hannula]

Klaus Schmidinger wrote:
> Anssi Hannula wrote:
> 
>> Klaus Schmidinger wrote:
>>
>>> Anssi Hannula wrote:
>>>
>>>> Klaus Schmidinger wrote:
>>>>
>>>>> After letting it run for a while suddenly this happened:
>>>>>
>>>>> Feb 18 15:19:42 video kernel: irq 5: nobody cared!
>>>>>
>>>>> Do you have any idea what might be the problem here?
>>>>
>>>>
>>>>
>>>> "irq #: nobody cared" is triggered when 99000 of 100000 IRQs are not 
>>>> handled, e.g. kfir_irq returns IRQ_NONE instead of IRQ_HANDLED. 
>>>> There was a "return 0" where should've been IRQ_NONE, but AFAIK that 
>>>> couldn't have been the cause of this error. Try this patch with 
>>>> debug=1 and test it with 100000+ interrupts. I added some debug 
>>>> printk's around return IRQ_NONE ("unhandled irq", "was audio irq", 
>>>> "was video irq").
>>>
>>>
>>>
>>> Done - log attached.
>>>
>>
>> Try this patch (against kfir-2.6-driver.tar.bz2).
>> ...
> 
> 
> Compiling gave me
> 
> /home/kls/vdr/KFIR/kfir-2.6-driver/kfir.c: In function `kfir_irq':
> /home/kls/vdr/KFIR/kfir-2.6-driver/kfir.c:1996: error: break statement 
> not within loop or switch
> 
> so I commented out line 1996.
> 
> I then had it running for some time (until there were more than 110000 
> IRQs)
> and all worked just fine).

:)

> 
> Let me know if removing line 1996 is ok and whether you want to
> make any further changes, so I can check this in to CVS.

Yeah, remove it.

You can commit the patch.

-- 
Anssi Hannula