[vdr] Repeatable vdr 1.3.35 crash at end of recording
Marko Mäkelä
marko.makela at hut.fi
Fri Nov 4 22:52:08 CET 2005
On Fri, Nov 04, 2005 at 02:51:01PM +0100, Klaus Schmidinger wrote:
> Marko Mäkelä wrote:
> >...
> >BTW, is there a reason why VDR discards the currently displayed menu
> >at the end of a recording?
>
> Not really, it just arose that way.
>
> This should fix it:
>
>
> --- vdr.c 2005/10/09 10:01:45 1.218
> +++ vdr.c 2005/11/04 13:48:39
> @@ -813,8 +813,14 @@
> if (Interact) {
> eOSState state = Interact->ProcessKey(key);
> if (state == osUnknown && Interact != cControl::Control()) {
> - if (ISMODELESSKEY(key) && cControl::Control())
> + if (ISMODELESSKEY(key) && cControl::Control()) {
> state = cControl::Control()->ProcessKey(key);
> + if (state == osEnd) {
> + // let's not close a menu when replay ends:
> + cControl::Shutdown();
> + continue;
> + }
> + }
> else if (time(NULL) - LastActivity > MENUTIMEOUT)
> state = osEnd;
> }
Thanks! Out of curiosity, I enabled the main menu (the one that shows
"stop playback" as the last entry) during playback. The item did not
go away when the playback ended. Of course, I had to select that item
when softdevice was already showing live program. It went black for
a couple of seconds and then resumed playing the live program.
For me, it's just a cosmetic thing. It's very nice that I can play with
the menus (such as browse the EPG) while watching a recording that is
about to end. However, perhaps someone with a hardware MPEG decoder
(FF card or DXR3) should test this patch?
Marko
More information about the vdr
mailing list