| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| *** | ChanServ sets mode: +v mchehab` | [07:20] |
| .................................... (idle for 2h55mn) | ||
| karatkievich.freenode.net sets mode: +v mchehab | [10:15] | |
| ...................... (idle for 1h46mn) | ||
| hverkuil | Meeting? | [12:01] |
| syoung | Hello | [12:01] |
| mkrufky | hi | [12:01] |
| hverkuil | mchehab: ping (let's see if that works)
In the meantime: I don't have anything to discuss. I plan to make at least one pull request tomorrow, but otherwise it's been quiet. | [12:04] |
| mkrufky | i've been away for thanksgiving, still reviewing brads patches, i'll ask him to post them to the mailing list soon
there's also that HUUUGE patch from sony... not sure when ill have time to review it, but i know its there | [12:07] |
| hverkuil | Is that cxd2880? | [12:08] |
| mkrufky | (thanksgiving - american holiday)
and yes | [12:08] |
| hverkuil | sailus: ping
pinchartl: ping | [12:08] |
| pinchartl | pong
sorry about the delay | [12:09] |
| hverkuil | pinchartl: can you look at Niklas' rcar-vin v8 patch series? I plan on reviewing it friday or monday since I really want to get this merged soon.
(you or Kieran, I guess) | [12:10] |
| sailus | Pong! | [12:11] |
| pinchartl | yes, I plan to do that tomorrow
it will be a big patch review day | [12:11] |
| syoung | I know mchehab asked if I could look at the sony patch series too. I'll have a look at some point, but I don't know how confident I'll be on the dvb side of things
mkrufky: ^^ | [12:11] |
| hverkuil | sailus: same question for you: can you review Niklas' rcar-csi2 v12 patch series? | [12:12] |
| sailus | hverkuil: Sure!
Likely tomorrow though. Is it: "[PATCH v8 00/28] rcar-vin: Add Gen3 with media controller"? No, "[PATCH v12 0/2] rcar-csi2: add Renesas R-Car MIPI CSI-2"? | [12:12] |
| hverkuil | No, it's: [PATCH v12 0/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 | [12:13] |
| mkrufky | syoung: i can look at the dvb specifics first .... looking at that driver as a whole, however, looks a bit overwhelming | [12:13] |
| sailus | Ack. | [12:13] |
| hverkuil | sailus: it doesn't hurt of course if you look at rcar-vin, specifically for the v4l2-async related code. | [12:14] |
| syoung | mkrufky: yes, there is the size and there are some interesting bits of the code | [12:14] |
| mkrufky | syoung: take a pass at it and feel free to draw my attention to specific parts if you have questions. i'll try to get to it as well | [12:14] |
| sailus | hverkuil: Indeed. | [12:14] |
| syoung | mkrufky: great, thanks. | [12:14] |
| sailus | I don't really have patches that needed reviews right now.
I've been doing some hacking on DVB related to object lifetime management but nothing to review yet. | [12:15] |
| mchehab | sorry, got late today | [12:15] |
| mkrufky | i have some time next week that i should be able to use to finish on Brad's series and start looking at sony | [12:15] |
| mchehab | mchehab is reading backlogs
from my side, I already applied today the pending git fix pull requests... I'm opting to send Linus for -rc2 the documentation warning fixes without them, we have a lot of new warnings (several hundreds) I'm starting right now to handle other pull requests the next one (I'm almost finished review) is the syoung RC patch series nice series, btw hurray! we finally got rid of staging/lirc | [12:15] |
| syoung | mchehab: thanks! | [12:19] |
| mchehab | there are a few issues with the documentation, like those:
./include/media/rc-core.h:96: warning: No description found for parameter 'int' ./include/media/rc-core.h:96: warning: No description found for parameter 'lirc_scancode' ./include/media/rc-core.h:96: warning: Excess struct member 'rawir' description in 'lirc_fh' ./include/media/rc-core.h:96: warning: Excess struct member 'scancodes' description in 'lirc_fh' but I'll fix in the way btw, not sure if anyone else noticed, but it seems that the documentation build is somewhat broken if -j option is used from time to time, I'm getting this Exception occurred: File "/home/mchehab/.local/lib/python2.7/site-packages/sphinx/util/parallel.py", line 97, in _join_one exc, result = pipe.recv() EOFError The full traceback has been saved in /tmp/sphinx-err-ZMo1P5.log, if you want to report the issue to the developers. | [12:20] |
| syoung | mchehab: right, those are DECLARE_KFIFO_PTR() members which are not parsed correctly | [12:21] |
| mchehab | after finishing with merges, I'll take a look, as this impacts my patch review process | [12:22] |
| syoung | mchehab: they do have documentation | [12:23] |
| mchehab | syoung: with regards to that patch, I didn't see Stefani's ack at the media ML | [12:23] |
| syoung | mchehab: that's an interesting one, it confused me at first too. | [12:24] |
| mchehab | better to double check if he's ok on having it merged via my ML
s/ML/tree | [12:24] |
| syoung | look at: https://patchwork.linuxtv.org/patch/44896/
that email was sent by Stefani (see show headers), but he sent it as me in fact, I got bounces from his email! that's where he added an Acked-by:, but obviously in a really weird way | [12:24] |
| mchehab | that's very weird... I'll reply and confirm with him and akpm if it would be ok to merge it via my tree | [12:28] |
| syoung | thanks
without that patch, creation of any rc device with a lirc chardev will fail on 32-bit (except i386) | [12:28] |
| mchehab | yes, I noticed
mkrufky, syoung: with regards to DVB, someone is complaining about compat32 stuff. I never actually tested using DVB API on 32 bits userspace/64 bits kernelspace. It would worth check if it is really broken... or if it is just a deprecated DVB API (I know that at least one of the deprecated API has an issue - due to a timestamp) hverkuil, sailus, pinchartl, mkrufky, syoung: anything else for today's discussions? | [12:29] |
| hverkuil | BTW: I'm working with Arnd on y2038 fixes for v4l2 api. I haven't posted anything yet, though. | [12:33] |
| mchehab | OK
yes, I've seen the emails | [12:33] |
| syoung | mchehab: where the complaint about dvd compat? ML? | [12:33] |
| mchehab | and discussions on irc | [12:33] |
| sailus | mchehab: Not on my side. | [12:33] |
| syoung | ah I found it | [12:33] |
| hverkuil | I'll be on vacation from Dec 16 - Jan 7. | [12:34] |
| mchehab | Subject: Re: [bug report] media: dvb_frontend: cleanup ioctl handling logic
Date: Thu, 30 Nov 2017 11:25:02 +0100 the complaint is pretty vague | [12:34] |
| mkrufky | we dont know if he's using DVB / v4l or both
i see the email now | [12:35] |
| mchehab | yes. and a report from someone named "Menion" is pretty suspecious | [12:36] |
| mkrufky | does it mean something?
"Menion" ? | [12:36] |
| mchehab | From: Menion <menion@gmail.com>From: Menion <menion@gmail.com> | [12:37] |
| mkrufky | oh. those little yellow characters with overalls. i thought those were "Minions" | [12:37] |
| mchehab | :-)
hard to tell who it is, as the e-mail was sent from google's webmail interface (based on its IP) I wouldn't answer the email, as it could be some troll, but it would be worth double-checking hverkuil: please send an e-mail to the ML with your vacation period | [12:38] |
| hverkuil | will do | [12:40] |
| mchehab | btw, I didn't have any time yet to consolidate the discussions about the summit report and send a draft to linux-media ML
mchehab would love someone to volunteer doing it :-p | [12:41] |
| hverkuil | mchehab: ask me again at the next meeting. I will probably have time the week after that, unless someone else picks this up. | [12:54] |
| mchehab | ok | [12:59] |
| ..... (idle for 22mn) | ||
| syoung: just sent 2 patches improving a little bit the RC documentation, after your patchset
I'll see if I find a way to solve the issue with DECLARE_KIFO_PTR later hmm... this is at kernel-doc: # replace DECLARE_BITMAP $members =~ s/DECLARE_BITMAP\s*\(([^,)]+), ([^,)]+)\)/unsigned long $1\[BITS_TO_LONGS($2)\]/gos; # replace DECLARE_HASHTABLE $members =~ s/DECLARE_HASHTABLE\s*\(([^,)]+), ([^,)]+)\)/unsigned long $1\[1 << (($2) - 1)\]/gos; it should likely be easy to add something similar for DECLARE_KIFO_PTR | [13:21] | |
| syoung: this does the trick:
# replace DECLARE_KFIFO_PTR(fifo, type) $members =~ s/DECLARE_KFIFO_PTR\s*\(([^,)]+),\s*([^,)]+)\)/$2 \*$1/gos; | [13:37] | |
| patch sent | [13:43] | |
| ........... (idle for 54mn) | ||
| syoung | mchehab: great, thank you. | [14:37] |
| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |