<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style>
***: karatkievich.freenode.net sets mode: +v mchehab
hverkuil: Meeting?
syoung: Hello
mkrufky: hi
hverkuil: <u>mchehab</u>: ping (let's see if that works)
<br> In the meantime: I don't have anything to discuss. I plan to make at least one pull request tomorrow, but otherwise it's been quiet.
mkrufky: i've been away for thanksgiving, still reviewing brads patches, i'll ask him to post them to the mailing list soon
<br> there's also that HUUUGE patch from sony...
<br> not sure when ill have time to review it, but i know its there
hverkuil: Is that cxd2880?
mkrufky: (thanksgiving - american holiday)
<br> and yes
hverkuil: <u>sailus</u>: ping
<br> <u>pinchartl</u>: ping
pinchartl: pong
<br> sorry about the delay
hverkuil: <u>pinchartl</u>: can you look at Niklas' rcar-vin v8 patch series? I plan on reviewing it friday or monday since I really want to get this merged soon.
<br> (you or Kieran, I guess)
sailus: Pong!
pinchartl: yes, I plan to do that tomorrow
<br> it will be a big patch review day
syoung: I know mchehab asked if I could look at the sony patch series too. I'll have a look at some point, but I don't know how confident I'll be on the dvb side of things
<br> <u>mkrufky</u>: ^^
hverkuil: <u>sailus</u>: same question for you: can you review Niklas' rcar-csi2 v12 patch series?
sailus: <u>hverkuil</u>: Sure!
<br> Likely tomorrow though.
<br> Is it: "[PATCH v8 00/28] rcar-vin: Add Gen3 with media controller"?
<br> No, "[PATCH v12 0/2] rcar-csi2: add Renesas R-Car MIPI CSI-2"?
hverkuil: No, it's: [PATCH v12 0/2] rcar-csi2: add Renesas R-Car MIPI CSI-2
mkrufky: <u>syoung</u>: i can look at the dvb specifics first .... looking at that driver as a whole, however, looks a bit overwhelming
sailus: Ack.
hverkuil: <u>sailus</u>: it doesn't hurt of course if you look at rcar-vin, specifically for the v4l2-async related code.
syoung: <u>mkrufky</u>: yes, there is the size and there are some interesting bits of the code
mkrufky: <u>syoung</u>: take a pass at it and feel free to draw my attention to specific parts if you have questions. i'll try to get to it as well
sailus: <u>hverkuil</u>: Indeed.
syoung: <u>mkrufky</u>: great, thanks.
sailus: I don't really have patches that needed reviews right now.
<br> I've been doing some hacking on DVB related to object lifetime management but nothing to review yet.
mchehab: sorry, got late today
mkrufky: i have some time next week that i should be able to use to finish on Brad's series and start looking at sony
-: mchehab is reading backlogs
mchehab: from my side, I already applied today the pending git fix pull requests...
<br> I'm opting to send Linus for -rc2 the documentation warning fixes
<br> without them, we have a lot of new warnings (several hundreds)
<br> I'm starting right now to handle other pull requests
<br> the next one (I'm almost finished review) is the syoung RC patch series
<br> nice series, btw
<br> hurray! we finally got rid of staging/lirc
syoung: <u>mchehab</u>: thanks!
mchehab: there are a few issues with the documentation, like those:
<br> ./include/media/rc-core.h:96: warning: No description found for parameter 'int'
<br> ./include/media/rc-core.h:96: warning: No description found for parameter 'lirc_scancode'
<br> ./include/media/rc-core.h:96: warning: Excess struct member 'rawir' description in 'lirc_fh'
<br> ./include/media/rc-core.h:96: warning: Excess struct member 'scancodes' description in 'lirc_fh'
<br> but I'll fix in the way
<br> btw, not sure if anyone else noticed, but it seems that the documentation build is somewhat broken if -j option is used
<br> from time to time, I'm getting this
<br> Exception occurred:
<br> File "/home/mchehab/.local/lib/python2.7/site-packages/sphinx/util/parallel.py", line 97, in _join_one
<br> exc, result = pipe.recv()
<br> EOFError
<br> The full traceback has been saved in /tmp/sphinx-err-ZMo1P5.log, if you want to report the issue to the developers.
syoung: <u>mchehab</u>: right, those are DECLARE_KFIFO_PTR() members which are not parsed correctly
mchehab: after finishing with merges, I'll take a look, as this impacts my patch review process
syoung: <u>mchehab</u>: they do have documentation
mchehab: <u>syoung</u>: with regards to that patch, I didn't see Stefani's ack at the media ML
syoung: <u>mchehab</u>: that's an interesting one, it confused me at first too.
mchehab: better to double check if he's ok on having it merged via my ML
<br> s/ML/tree
syoung: look at: https://patchwork.linuxtv.org/patch/44896/
<br> that email was sent by Stefani (see show headers), but he sent it as me
<br> in fact, I got bounces from his email!
<br> that's where he added an Acked-by:, but obviously in a really weird way
mchehab: that's very weird... I'll reply and confirm with him and akpm if it would be ok to merge it via my tree
syoung: thanks
<br> without that patch, creation of any rc device with a lirc chardev will fail on 32-bit (except i386)
mchehab: yes, I noticed
<br> mkrufky, syoung: with regards to DVB, someone is complaining about compat32 stuff. I never actually tested using DVB API on 32 bits userspace/64 bits kernelspace. It would worth check if it is really broken...
<br> or if it is just a deprecated DVB API
<br> (I know that at least one of the deprecated API has an issue - due to a timestamp)
<br> hverkuil, sailus, pinchartl, mkrufky, syoung: anything else for today's discussions?
hverkuil: <u>BTW</u>: I'm working with Arnd on y2038 fixes for v4l2 api. I haven't posted anything yet, though.
mchehab: OK
<br> yes, I've seen the emails
syoung: <u>mchehab</u>: where the complaint about dvd compat? ML?
mchehab: and discussions on irc
sailus: <u>mchehab</u>: Not on my side.
syoung: ah I found it
hverkuil: I'll be on vacation from Dec 16 - Jan 7.
mchehab: <u>Subject</u>: Re: [bug report] media: dvb_frontend: cleanup ioctl handling logic
<br> <u>Date</u>: Thu, 30 Nov 2017 11:25:02 +0100
<br> the complaint is pretty vague
mkrufky: we dont know if he's using DVB / v4l or both
<br> i see the email now
mchehab: yes. and a report from someone named "Menion" is pretty suspecious
mkrufky: does it mean something?
<br> "Menion" ?
mchehab: <u>From</u>: Menion <menion@gmail.com>From: Menion <menion@gmail.com>
mkrufky: oh. those little yellow characters with overalls. i thought those were "Minions"
mchehab: :-)
<br> hard to tell who it is, as the e-mail was sent from google's webmail interface
<br> (based on its IP)
<br> I wouldn't answer the email, as it could be some troll, but it would be worth double-checking
<br> <u>hverkuil</u>: please send an e-mail to the ML with your vacation period
hverkuil: will do
mchehab: btw, I didn't have any time yet to consolidate the discussions about the summit report and send a draft to linux-media ML
-: mchehab would love someone to volunteer doing it :-p
hverkuil: <u>mchehab</u>: ask me again at the next meeting. I will probably have time the week after that, unless someone else picks this up.
mchehab: ok
<br> <u>syoung</u>: just sent 2 patches improving a little bit the RC documentation, after your patchset
<br> I'll see if I find a way to solve the issue with DECLARE_KIFO_PTR later
<br> hmm...
<br> this is at kernel-doc:
<br> # replace DECLARE_BITMAP
<br> $members =~ s/DECLARE_BITMAP\s*\(([^,)]+), ([^,)]+)\)/unsigned long $1\[BITS_TO_LONGS($2)\]/gos;
<br> # replace DECLARE_HASHTABLE
<br> $members =~ s/DECLARE_HASHTABLE\s*\(([^,)]+), ([^,)]+)\)/unsigned long $1\[1 << (($2) - 1)\]/gos;
<br> it should likely be easy to add something similar for DECLARE_KIFO_PTR
<br> <u>syoung</u>: this does the trick:
<br> # replace DECLARE_KFIFO_PTR(fifo, type)
<br> $members =~ s/DECLARE_KFIFO_PTR\s*\(([^,)]+),\s*([^,)]+)\)/$2 \*$1/gos;
<br> patch sent
syoung: <u>mchehab</u>: great, thank you.