<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style>
mchehab: one of the reasons why we were using cflags were due to the old building system. With the new one, it is easy to fix things like that - and we do it already with include/media/i2c
<br> and other similar stuff
<br> backport patches that touch header files could need changes, but I don't think there are any touching at the dvb header files
<br> <u>sailus</u>: with regards to that patch series that document mc-centric stuff, I opted to not resend it for now, as I've no idea what changes we agreed. I recall that you were supposed to send us something
<br> I'd appreciate if you could do it early-2018, if possible, in time for merging it to 4.16
sailus: <u>mchehab</u>: Something? :-)
<br> I can revisit the patchset, but right now I don't remember what this might have exactly been. :-o
mchehab: I don't remember the details, but I guess you would either be sending a proposal or writing a meeting notes
<br> (or both?)
<br> the main topic where focused on what name we should use for non-subdev, non-mc device nodes created by V4L2 core
<br> e. g. a definition that includes /dev/{video,vbi,radio,swradio,v4l-touch}", but will exclude /dev/v4l-subdev
<br> on a separate topic, I'm starting to review the cio2 patchset
<br> patch 2 generates 4 new doc warnings:
<br> /devel/v4l/patchwork/Documentation/output/videodev2.h.rst:6: WARNING: undefined label: v4l2-pix-fmt-ipu3-sbggr10 (if the link has no caption the label must precede a section header)
<br> /devel/v4l/patchwork/Documentation/output/videodev2.h.rst:6: WARNING: undefined label: v4l2-pix-fmt-ipu3-sgbrg10 (if the link has no caption the label must precede a section header)
<br> /devel/v4l/patchwork/Documentation/output/videodev2.h.rst:6: WARNING: undefined label: v4l2-pix-fmt-ipu3-sgrbg10 (if the link has no caption the label must precede a section header)
<br> /devel/v4l/patchwork/Documentation/output/videodev2.h.rst:6: WARNING: undefined label: v4l2-pix-fmt-ipu3-srggb10 (if the link has no caption the label must precede a section header)
<br> probably, videodev2.h.rst.exceptions need to be patched
sailus: Right, now I vaguely remember this. We didn't discuss all that many topics in the meeting indeed. I'll send notes on that. Thanks for the reminder.
<br> Ouch, I'll check the documentation patches.
mchehab: argh, a macro named arr_size() with a different meaning than ARR_SIZE() is risky...
<br> someone might send a patch replacing it some day
<br> also, such macros should be in upper case
<br> this doesn't block merge, but it would be good if you could send a patch replacing it by a better name
<br> (patch 3)
<br> +#define arr_size(a) ((a)->end - (a)->begin + 1)
<br> btw, that entire code is weird: cio2_fbpt_rearrange()
<br> what are it rearranging? buffers? why?
sailus: It's rearranging buffer pointers that are accessed by the hardware.
<br> The hardware starts from the beginning when it is woken up after sleep.
<br> But the V4L2 buffers don't work that way, the hardware must continue processing from the next buffer, not first.
<br> The documentation fix is trivial.
mchehab: this happens just when woken up after sleep?
sailus: When the hardware is restarted essentially.
<br> The streaming state is maintained over sleep.
<br> So in this case the array is rearranged.
<br> Would you be fine with pulling this, and adding the fixes on top, or change the existing patches?
mchehab: if those are the only issues, you can send separate patches
sailus: Ack. Let me know if there's something else.
mchehab: yeah, that's it
<br> I guess I was expecting more patches :-)
sailus: :-)
mchehab: patches applied
<br> I'll merge right now the patches that fix those warnings:
<br> ./include/media/v4l2-async.h:80: warning: Function parameter or member 'match.fwnode' not described in 'v4l2_async_subdev'
<br> I missed some dmxdev warnings due to that!
<br> as it is producing 20 warnings
sailus: Obrigado!
<br> I'll send the two patches addressing the issues above.
mchehab: OK
***: ChanServ sets mode: +v mchehab`
mchehab: ok, we're now warning-free again when building the documentation :-)
<br> and the DVB kAPI documentation is again in sync with the implementation
<br> we still need to make the V4L2 API in sync, but that's a hard work :-)
<br> s/API/kAPI/
sailus: That's very nice indeed.
<br> How about the meeting notes on Prague meeting btw.?
<br> I remember there was discussion and a bunch of comments but I haven't seen any notes publicly.
<br> It'd be good to have them out, even if they're not perfect.
mchehab: heh... didn't have time to work on it yet :-(
<br> need to consolidate all comments into a new version
<br> and submit the draft to linux-media
<br> for a final review
sailus: That'd be great.
<br> It's easier to refer to meeting notes when they exist. ;-)
mchehab: :-)
<br> well, someone needs time to look at the replies :-)
<br> I won't be sad if you volunteer yourself :-D