| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| *** | pinchartl has quit IRC (Read error: Connection reset by peer) | [09:35] |
| .......... (idle for 48mn) | ||
| sailus | mchehab: Yes. I think his mail server has a (virtual) hardware problem. | [10:23] |
| .... (idle for 15mn) | ||
| mchehab | sailus: btw, not sure if you saw: https://patchwork.linuxtv.org/patch/48625/
IMHO, the __user annotations are a way clearer now That weird m.planes annotation how became: - if (get_user(uplane, ((__force struct v4l2_plane __user **)&kp->m.planes))) + if (get_user(uplane, &kp->m.planes)) After this change: - struct v4l2_plane __user *uplane; + struct v4l2_plane *uplane; the reason is that get_user() expects a KS reference as its first argument and not a __user one | [10:38] |
| ......... (idle for 40mn) | ||
| sailus | I think the cast is useless.
There's no cast two lines below. I hate compat code. The pointer is still pointing to memory mapped to user space, therefore __user would be appropriate. Ah, yes, I see you indeed remove the useless cast. Good. :-) Could we not use compat_ptr() for the purpose, as is done for uplane32? As the memory is mapped to user space, I presume the address fits to 32 bits. | [11:20] |
| .............. (idle for 1h7mn) | ||
| Nah, that's not good either.
Perhaps just casting it as non-user pointer? | [12:31] | |
| ..... (idle for 21mn) | ||
| *** | hverkuil_ has quit IRC (Ping timeout: 245 seconds)
ChanServ sets mode: +v hverkuil | [12:52] |
| ............. (idle for 1h1mn) | ||
| mchehab | I tried several other variations, the ones it does are the ones that smatch doesn't complain
smatch has a very good validator for __user on some cases casting as non-user pointer cause troubles that's why I opted to declare the var without __user on some parts... and explicitly cast as __user where needed this reduces the need of __force (with actually disables smatch address space validator and it is the only way to cast an __user pointer as a "non-user" one | [13:57] |
| ........................................................................................................ (idle for 8h37mn) | ||
| *** | ChanServ sets mode: +v mchehab` | [22:36] |
| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |