[11:06] <mchehab> sailus, hverkuil: btw please check if everything is ok with the latest version of the glossary patch: https://patchwork.linuxtv.org/patch/52334/ [11:06] <mchehab> It addresses the latest comments from you both. [11:06] <pinchartl> mchehab: I'm reviewing it, I'll have a few comments [11:07] <mchehab> ok [11:08] <sailus> I'll try to review it later today. [11:08] <mchehab> please notice that the idea here is to remove items that would cause further discussions [11:08] <mchehab> (so, I removed vdev-centric x mc-centric) [11:08] <mchehab> once this gets merged, I'll work on those pending stuff [11:11] <hverkuil> mchehab: reviewed v4: more typos, some new, some old. [11:12] <mchehab> pinchartl: please also review those two patches: [11:12] <mchehab> https://git.linuxtv.org/mchehab/experimental.git/commit/?h=mc-centric-flag-v9&id=36c28cfd59757585e04738d65afdc833de7b8042 [11:12] <mchehab> https://git.linuxtv.org/mchehab/experimental.git/commit/?h=mc-centric-flag-v9&id=8a9858cb144d47a633682d17ccdf531e6ef04e68 [11:12] <mchehab> they addresses some comments you've made to a /13 patch series that got merged [11:16] <mchehab> hverkuil: thanks! [11:41] <pinchartl> mchehab: glossary reviewed [11:58] <hverkuil> hi! [11:58] <mkrufky> hi [12:03] <hverkuil> mchehab: sailus: pinchartl: syoung: ping [12:05] <syoung> hi [12:05] <pinchartl> pong ? [12:05] <mchehab> hi all [12:06] <mchehab> pinchartl: thanks! [12:06] <mchehab> (it seems that vger is a little slow today) [12:07] <hverkuil> I think we can start, only sailus is not here yet. [12:07] <mchehab> yep [12:08] <hverkuil> I guess our merge window will close tomorrow or perhaps on Monday? [12:08] <mchehab> yeah, I'll likely merge the last patches on Monday [12:09] <mkrufky> mchehab: i had some trouble moving the pgp keys., ill get it eventually, but may I sent today the patches I have queued without signing the PR? [12:09] <mkrufky> i'll fix this up for the future [12:09] <mchehab> syoung: I remember there are some pending stuff from you [12:09] <syoung> mchehab: yes, there is https://patchwork.linuxtv.org/patch/51787/ [12:10] <mchehab> ok, will look at it. The old PR is superseed? if so please mark it at patchwork (if you haven't done it yet) [12:10] <mchehab> mkrufky: this time, ok, but please fix it asap [12:10] <syoung> no, it is not. We discussed it and the plan was that you would drop the first two n900 patches [12:10] <mkrufky> of course. thanks [12:11] <mchehab> syoung: ah, sorry, I forgot that :-) [12:12] <hverkuil> I think there is one pull request pending from me ('various fixes'). [12:12] <hverkuil> There will be one more for CEC issues (patch series posted today, but it will need a bit more testing before I make a pull request). [12:13] <mchehab> yeah, better to place them at the next merge window [12:13] <mchehab> there's one pending patch series from my side too... [12:14] <mchehab> related to LGPL with invariant sections [12:14] <hverkuil> mchehab: who were you replying to? 'yeah, better to place them at the next merge window' [12:14] <mchehab> (CEC patches) [12:14] <hverkuil> They are for 4.20. And probably with a CC for stable. [12:14] <mchehab> the LGPL series is waiting for pinchartl and sailus SOB [12:15] <syoung> I'm going to the ELCE in Edinburgh by train. Anything I can bring to make life easier for everyone? I just thought I'd ask. [12:15] <hverkuil> syoung: a nice whisky? :-) [12:16] <syoung> well we'd buy that in Scotland, I would think :-) [12:16] <syoung> but sure :) [12:16] <mchehab> hverkuil: Edinburgh should have good Scotch :-D [12:16] <sailus> Hello! [12:16] <hverkuil> you can serve it at the media summit: I'm sure we'll get all 75 registered people in that case :-) [12:17] <hverkuil> I'm planning to go whisky shopping on Friday :-) [12:17] <mchehab> well, if we'll start serving Scotch there, and people see the logs from this channel, I'm pretty sure that we'll have a lot more than 75 people :-p [12:18] <syoung> hverkuil: there are some great whisky bars in Edinburgh :) [12:18] <mchehab> syoung: (being serious now) just your presence is enough [12:18] * pinchartl was thinking about bringing tea, but that might end up being less popular [12:19] <sailus> pinchartl: Please do! [12:19] <syoung> tea is always nice [12:19] <sailus> I'll se if I could bring a pot. [12:20] <hverkuil> BTW, Helen Koike and me are co-mentors for an Outreachy project to add stateless codec support to vicodec and add test code to v4l2-compliance for testing such codecs. [12:20] <pinchartl> please note that I only have teas that can't be mixed with sugar or milk (they explode otherwise :-)) [12:20] <hverkuil> Fingers crossed, hope we'll find a good candidate. [12:20] <pinchartl> hverkuil: nice! who will you mentor, one or multiple candidates ? [12:20] <pinchartl> ah ok you don't know yet :-) [12:20] <hverkuil> one [12:21] <syoung> pinchartl: that sounds like an experiment ;) [12:21] <hverkuil> dunno who yet (the next round just opened) [12:22] <hverkuil> I got a bit behind reviewing patches on the list: anything that I should review today/tomorrow? [12:24] <hverkuil> syoung: can you review https://patchwork.linuxtv.org/patch/52315/? [12:24] <sailus> mchehab: I'll send another pull request for a couple of sensor drivers after you've handled the fwnode one. As the sole problem that required resubmitting was the author / SoB problem that is now resolved, I suppose that should now be fine. [12:24] <mchehab> ok, good [12:24] <mchehab> I'll look them [12:25] <syoung> hverkuil: yes, will do. Thanks for reminding me. [12:27] <hverkuil> Anything else? [12:28] <mchehab> from my side, no [15:03] <mchehab> pinchartl: sent a version 5 of the glossary addressing your suggestions [15:05] <mchehab> Had to do some cosmetical changes in order to use things like: :term:`DSP` [15:05] <mchehab> basically, the name of the term is the acronym, instead of a full name, for all terms that have acronyms [15:06] <mchehab> and I had to add an extra line for the "full name" for acronyms [17:06] <pinchartl> mchehab: thanks, I'll review that [17:06] <mchehab> thank you! [17:07] <mchehab> That's the latest version: https://patchwork.linuxtv.org/patch/52346/ [18:20] <mchehab> syoung: the ktest patch should probably go via Shuah's tree [18:21] <mchehab> I'll ping her about it... [18:21] <mchehab> skipping applying it for now, while I don't hear from her [19:50] <syoung> mchehab: ok. FYI The bpf folks include ktests in their tree. [19:51] <mchehab> I forwarded the patch to Shuah [19:51] <mchehab> I guess she'll apply directly [19:51] <mchehab> on her tree [19:52] <mchehab> when it depends on new stuff, the usual procedure is to get her ack [19:52] <mchehab> otherwise, it comes via the the ktest tree [20:01] <syoung> ok, now I understand. Thanks for dealing with that [20:02] <mchehab> anytime [20:02] <mchehab> btw, you forgot to c/c here on your patch [20:02] <mchehab> every time you write something outside drivers/media, please run ./scripts/get_maintainers.pl [20:03] <mchehab> in order to verify if someone else need to be c/c [20:10] <syoung> thanks, I'll try to remember. Not the first time I forget, I think. [20:15] <mchehab> sailus: [20:16] <mchehab> drivers/media/v4l2-core/v4l2-fwnode.c: In function 'v4l2_fwnode_endpoint_parse_parallel_bus': [20:16] <mchehab> drivers/media/v4l2-core/v4l2-fwnode.c:186:15: warning: comparison between 'enum v4l2_fwnode_bus_type' and 'enum v4l2_mbus_type' [-Wenum-compare] [20:16] <mchehab> if (bus_type == V4L2_MBUS_PARALLEL || bus_type == V4L2_MBUS_BT656) [20:16] <mchehab> ^~ [20:16] <mchehab> drivers/media/v4l2-core/v4l2-fwnode.c:186:49: warning: comparison between 'enum v4l2_fwnode_bus_type' and 'enum v4l2_mbus_type' [-Wenum-compare] [20:16] <mchehab> if (bus_type == V4L2_MBUS_PARALLEL || bus_type == V4L2_MBUS_BT656) [20:16] <mchehab> ^~ [20:16] <mchehab> "media: v4l: fwnode: Use default parallel flags" [20:17] <mchehab> Clearly, there is an issue there [20:19] <mchehab> or maybe it should be fold with "media: v4l: fwnode: Use media bus type for bus parser selection" [20:19] <mchehab> or go after it [20:22] <mchehab> ok, moving it to be applied after solved the warning. I'll move here [22:30] <sailus> mchehab: I believe that problem is addressed in a later patch indeed. [22:31] <sailus> I've been mostly relying on the kbuild bot on testing individual patches as it usually uncovers a lot more errors than compiling on a single system only. [22:32] <sailus> I'm off to bed now, hyvää yötä! :-)