sailus: did you send the PR before pushing the branch at the server?
mchehab: No.
I pushed it first. git usually complains fairly loudly if it can't see the patches on the server.
It's a tag btw., not a branch.
Which Patchwork state should I use for patches that are not destined to the media tree? Not applicable?
yep
sailus: I'm trying to understand what happened here: https://builder.linuxtv.org/job/patchwork/8455/console
basically, it is failing to fetch from your tree
I tested locally, and it is ok
I added some extra error handling logic at the builder script in order to get such errors
I saw that error, to.
s/\Ko/o/
"Host key verification failed." ?
I'm not caring too much for key signatures at this point... not sure why, but either people are forgetting to sign branches, or git verify-tag is failing for no reason
I'm getting some inconsistent results with these lately
I signed it the same way I did on the previous time.
And I presume it worked then.
Interesting.
but the real problem is that it was not able to produce a quilt tree from your branch
It also says it could not read from the remote branch, and appantely that's because it could not verify the host key.
s/appantely/apparently/
sailus: how did you change the linuxtv.org host key for your git tree ? :-)
sailus: I doubt that "read from remote branch" means that
the command the script uses to verify is this:
$ git verify-tag FETCH_HEAD
provided that this command doesn't fail:
$ git pull -q --no-edit --ff ssh://linuxtv.org/git/sailus/media_tree.git tags/for-5.4-4-signed
the FETCH_HEAD should be there
Could there be another host lurking out somewhere and using the same IP address with a different host key?
Just a wild guess.
hmm... you're using ssh:// instead of git:// on pull requests...
I've been using that for many, many years by now. :-)
The authenticity of host 'linuxtv.org (130.149.80.248)' can't be established.
please prefer to use git:// instead...
as people without account at linuxtv.org won't be able to fetch from ssh://
...what?
and, btw, jenkins doesn't have an account at linuxtv.org
How did that use to work?
git fetch ssh://linuxtv.org/git/sailus/media_tree.git tags/for-5.4-4-signed
jenkins@linuxtv.org: Permission denied (publickey).
fatal: Could not read from remote repository.
Or did it not use to work?
it works because *I* have an account there
:-D
so, I can fetch
Ok, I'll use git://, and resend.
ok
Thanks!
let's see if it will handle it fine this time
thanks!
btw, I guess fetch using git:// instead of ssh:// is faster
(not that this really matter anyway)
It's generally not a great idea to use git:// over the Internet. But the tags are signed and that helps a lot.
But I can see it doesn't make much of a difference here.
I don't see any problem on using git over the internet
How often do you verify the signatures after a fetch?
And... how often there even are signatures?
always
it is on my scripts
For pull requests, yes.
both at jenkins and on my local scripts
ssh helps a little in absence of a way to check the signature.
added an explicit check for ssh:// URLS, making it return earlier and provide an error message
s/URLS/URLs/
sailus: let's see how it behaves on your next PR with git: instead of ssh:
syoung: with regards to: https://www.mail-archive.com/linux-media@vger.kernel.org/msg149100.html
not sure what you're meaning by two patches
mchehab: Sent. I added a few more patches I had applied since.
ok, thanks!
https://builder.linuxtv.org/job/patchwork/8483/console
it recognized your GPG signature
I interrupted the job in order to address this invalid errror:
07:34:08 error: tag '2' not found.
(that was a problem at the script - already fixed)
https://builder.linuxtv.org/job/patchwork/8485/console
I'll let this job to run until the end
if everything is ok, it should now print the GPG verify message at the e-mail too
syoung: are you generating the pull tags with your GPG key?
mchehab: I didn't use my GPG key. I'll do that next time.
about https://www.mail-archive.com/linux-media@vger.kernel.org/msg149100.html this had two parts: remove t230 from cxusb driver, and support to the dvbsky driver.
either way would work
syoung: please send me the gpg key ID before the pull request, for me to add at the build server
sure
ok
sailus: pinchartl: fyi, I'll let the builder run again with your PR's, just to be sure that it will now send the e-mail automatically, and that it will show that your keys are trusted
Output for GPG check now looks good enough for me:
14:33:50 gpg: Signature made Wed 14 Aug 2019 10:10:12 AM UTC
14:33:50 gpg:                using DSA key F0D0377A0D4F25A79238EFE56D40361B6E28C193
14:33:50 gpg:                issuer "sakari.ailus@linux.intel.com"
14:33:50 gpg: Good signature from "Sakari Ailus <sakari.ailus@linux.intel.com>" [full]
sailus: with regards to your PR, my understanding from the jenkins builder is that there are a few things to be addressed. So, I'll mark it as changes requested