<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style>
mchehab: <u>sailus</u>: did you send the PR before pushing the branch at the server?
sailus: <u>mchehab</u>: No.
<br> I pushed it first. git usually complains fairly loudly if it can't see the patches on the server.
<br> It's a tag btw., not a branch.
<br> Which Patchwork state should I use for patches that are not destined to the media tree? Not applicable?
mchehab: yep
<br> <u>sailus</u>: I'm trying to understand what happened here: https://builder.linuxtv.org/job/patchwork/8455/console
<br> basically, it is failing to fetch from your tree
<br> I tested locally, and it is ok
<br> I added some extra error handling logic at the builder script in order to get such errors
sailus: I saw that error, to.
<br> s/\Ko/o/
<br> "Host key verification failed." ?
mchehab: I'm not caring too much for key signatures at this point... not sure why, but either people are forgetting to sign branches, or git verify-tag is failing for no reason
<br> I'm getting some inconsistent results with these lately
sailus: I signed it the same way I did on the previous time.
<br> And I presume it worked then.
<br> Interesting.
mchehab: but the real problem is that it was not able to produce a quilt tree from your branch
sailus: It also says it could not read from the remote branch, and appantely that's because it could not verify the host key.
<br> s/appantely/apparently/
pinchartl: <u>sailus</u>: how did you change the linuxtv.org host key for your git tree ? :-)
mchehab: <u>sailus</u>: I doubt that "read from remote branch" means that
<br> the command the script uses to verify is this:
<br> $ git verify-tag FETCH_HEAD
<br> provided that this command doesn't fail:
<br> $ git pull -q --no-edit --ff ssh://linuxtv.org/git/sailus/media_tree.git tags/for-5.4-4-signed
<br> the FETCH_HEAD should be there
sailus: Could there be another host lurking out somewhere and using the same IP address with a different host key?
<br> Just a wild guess.
mchehab: hmm... you're using ssh:// instead of git:// on pull requests...
sailus: I've been using that for many, many years by now. :-)
mchehab: The authenticity of host 'linuxtv.org (130.149.80.248)' can't be established.
<br> please prefer to use git:// instead...
<br> as people without account at linuxtv.org won't be able to fetch from ssh://
sailus: ...what?
mchehab: and, btw, jenkins doesn't have an account at linuxtv.org
sailus: How did that use to work?
mchehab: git fetch ssh://linuxtv.org/git/sailus/media_tree.git tags/for-5.4-4-signed
<br> jenkins@linuxtv.org: Permission denied (publickey).
<br> <u>fatal</u>: Could not read from remote repository.
sailus: Or did it not use to work?
mchehab: it works because *I* have an account there
sailus: :-D
mchehab: so, I can fetch
sailus: Ok, I'll use git://, and resend.
mchehab: ok
sailus: Thanks!
mchehab: let's see if it will handle it fine this time
<br> thanks!
<br> btw, I guess fetch using git:// instead of ssh:// is faster
<br> (not that this really matter anyway)
sailus: It's generally not a great idea to use git:// over the Internet. But the tags are signed and that helps a lot.
<br> But I can see it doesn't make much of a difference here.
mchehab: I don't see any problem on using git over the internet
sailus: How often do you verify the signatures after a fetch?
<br> And... how often there even are signatures?
mchehab: always
<br> it is on my scripts
sailus: For pull requests, yes.
mchehab: both at jenkins and on my local scripts
sailus: ssh helps a little in absence of a way to check the signature.
mchehab: added an explicit check for ssh:// URLS, making it return earlier and provide an error message
<br> s/URLS/URLs/
<br> <u>sailus</u>: let's see how it behaves on your next PR with git: instead of ssh:
<br> <u>syoung</u>: with regards to: https://www.mail-archive.com/linux-media@vger.kernel.org/msg149100.html
<br> not sure what you're meaning by two patches
sailus: <u>mchehab</u>: Sent. I added a few more patches I had applied since.
mchehab: ok, thanks!
<br> https://builder.linuxtv.org/job/patchwork/8483/console
<br> it recognized your GPG signature
<br> I interrupted the job in order to address this invalid errror:
<br> 07:34:08 error: tag '2' not found.
<br> (that was a problem at the script - already fixed)
<br> https://builder.linuxtv.org/job/patchwork/8485/console
<br> I'll let this job to run until the end
<br> if everything is ok, it should now print the GPG verify message at the e-mail too
<br> <u>syoung</u>: are you generating the pull tags with your GPG key?
syoung: <u>mchehab</u>: I didn't use my GPG key. I'll do that next time.
<br> about https://www.mail-archive.com/linux-media@vger.kernel.org/msg149100.html this had two parts: remove t230 from cxusb driver, and support to the dvbsky driver.
mchehab: either way would work
<br> <u>syoung</u>: please send me the gpg key ID before the pull request, for me to add at the build server
syoung: sure
<br> ok
mchehab: <u>sailus</u>: pinchartl: fyi, I'll let the builder run again with your PR's, just to be sure that it will now send the e-mail automatically, and that it will show that your keys are trusted
<br> Output for GPG check now looks good enough for me:
<br> 14:33:50 gpg: Signature made Wed 14 Aug 2019 10:10:12 AM UTC
<br> 14:33:50 gpg: using DSA key F0D0377A0D4F25A79238EFE56D40361B6E28C193
<br> 14:33:50 gpg: issuer "sakari.ailus@linux.intel.com"
<br> 14:33:50 gpg: Good signature from "Sakari Ailus <sakari.ailus@linux.intel.com>" [full]
<br> <u>sailus</u>: with regards to your PR, my understanding from the jenkins builder is that there are a few things to be addressed. So, I'll mark it as changes requested